WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 2 years ago

#26962 new enhancement

in wp-admin/profile.php no restoration filled if an error occurs fields.

Reported by: QuarkSEO Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 2.0
Component: Users Keywords: needs-patch
Focuses: administration Cc:

Description

I just saw that if the fields are filled and that we delete such a required fields (or causing an error in the syntax of email for example), no mechanism is in place to restore the information specified by the user, everything is reset.
This mechanism is however in place in the "wp-admin/user-new.php" when we disable javascript.

Change History (5)

#1 @bcworkz
4 years ago

  • Keywords reporter-feedback added

I cannot replicate the same conditions. Would you please provide a 'walk through' for us to follow so we can see the same conditions?

There aren't many required fields. The username cannot be changed at all. If one deletes the nickname, it is replaced by a copy of the username, the default value. It does not revert to an old value if it was different from the default. This is the only thing that remotely resembles what you are talking about. Any invalid or blank email I try to submit does revert to the original value. The password cannot be deleted. Leaving the fields blank does not change anything. Putting in anything other than a matched string for password does not change anything. Of course a matched string changes the password to that string.

I believe that covers all the required fields. No matter what I do, I cannot cause the profile to be in an unusable state.

Last edited 4 years ago by bcworkz (previous) (diff)

#2 @QuarkSEO
4 years ago

I did a demonstration of "problem" video ..
I hope it will be enough and you will understand the problem

https://vimeo.com/85519889
password video : wordpress

#3 @bcworkz
4 years ago

  • Keywords reporter-feedback removed

Thank you for the video, I understand now and I get the same problem. For anyone that doesn't want to watch videos, the issue is when new text is entered in any field along with an erroneous email or something else that will throw an error, when the page is submitted and the error displayed, the text entered on the previous page is gone, apparently requiring the user to re-enter the data.

If one spent a lot of time composing the perfect Bio, this would be very frustrating!

If this happens to anyone before this issue can be addressed, use your browser's back button to get the text previously entered to re-appear.

#4 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Users
  • Keywords needs-patch added
  • Version changed from 3.8 to 2.0

Confirmed.

edit_user() doesn't update anything if there's an error in username, e-mail, or password, so the data entered in other fields is lost. It should probably unset the ones with errors (to prevent them from being saved), but still save the others.

user-new.php just displays the values from $_POST (the user is not created yet), so the "Add New User" screen doesn't have this issue.

#5 @chriscct7
2 years ago

  • Focuses administration added
Note: See TracTickets for help on using tickets.