Opened 9 years ago
Closed 9 years ago
#27051 closed defect (bug) (fixed)
Twenty Fourteen: Trigger Masonry after document load
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | 3.8.1 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
This may fix an issue with widgets (like the Facebook or Twitter Timeline widgets) that load iframes and break out of the footer widget container due to Masonry firing before they've loaded. I'm not sure it's the best solution, however, and needs further testing.
Attachments (3)
Change History (16)
This ticket was mentioned in IRC in #wordpress-themes by lancewillett. View the logs.
9 years ago
This ticket was mentioned in IRC in #wordpress-themes by lancewillett. View the logs.
9 years ago
#6
@
9 years ago
Steps to reproduce:
- Activate Twenty Fourteen
- Add a widget with an iframe and a height that's taller than the footer (I used the Twitter Timeline widget with a height of 800px) to the Footer Widget Area.
- Check the site, and note the widget breaks out of the footer container, like so: https://cloudup.com/c2nNB5uk3xQ
- Happens for me in the latest versions of Chrome, Safari, and Firefox for Mac
#8
@
9 years ago
- Keywords needs-testing added
Hmm, patch doesn't resolve the issue for me. When viewing a new page (after hard refresh and bumping the JS version) the widget still overlaps the footer.
#9
@
9 years ago
With the example of Twitter Timeline widget, even if the Masonry JS loads after the body loads -- the widget content itself loads asynchronously so Masonry would need to re-load after any third-party scripts finish. Which sounds complicated to solve.
This ticket was mentioned in IRC in #wordpress-themes by lancewillett. View the logs.
9 years ago
#12
@
9 years ago
- Keywords needs-testing removed
Chatting about this in IRC today, best course seems to go ahead with the onload delay to give more time for things to load before Masonry kicks in. But, we can't account for all the myriad widgets out there that load asynchronously without a set height.
Nice catch Caroline! Have tested if it work if we moved the masonry call in the
_window.load
callback?