Twenty Fourteen: Trigger Masonry after document load

[sixhours]

This may fix an issue with widgets (like the Facebook or Twitter Timeline widgets) that load iframes and break out of the footer widget container due to Masonry firing before they've loaded. I'm not sure it's the best solution, however, and needs further testing.

[obenland]

Nice catch Caroline! Have tested if it work if we moved the masonry call in the _window.load callback?

[sixhours]

I did test it in that callback first, but it did not work for me.

[sixhours]

Steps to reproduce:

• Activate Twenty Fourteen
• Add a widget with an iframe and a height that's taller than the footer (I used the Twitter Timeline widget with a height of 800px) to the Footer Widget Area.
• Check the site, and note the widget breaks out of the footer container, like so: ​https://cloudup.com/c2nNB5uk3xQ
• Happens for me in the latest versions of Chrome, Safari, and Firefox for Mac

[obenland]

27051.diff​ fixes the outlined example for me.

[lancewillett]

Hmm, patch doesn't resolve the issue for me. When viewing a new page (after hard refresh and bumping the JS version) the widget still overlaps the footer.

[lancewillett]

With the example of Twitter Timeline widget, even if the Masonry JS loads after the body loads -- the widget content itself loads asynchronously so Masonry would need to re-load after any third-party scripts finish. Which sounds complicated to solve.

[lancewillett]

Bump the JS version also, and spacing fix

[lancewillett]

Possibly related:

• ​https://dev.twitter.com/discussions/9501
• ​http://stackoverflow.com/questions/11681919/embedded-tweets-completion-event

[lancewillett]

Chatting about this in IRC today, best course seems to go ahead with the onload delay to give more time for things to load before Masonry kicks in. But, we can't account for all the myriad widgets out there that load asynchronously without a set height.

[lancewillett]

In 27627:

Twenty Fourteen: load Masonry after window load event to give more time for widget content to load before drawing the layout. Closes #27051.