WordPress.org

Make WordPress Core

#27100 closed task (blessed) (fixed)

Update the TinyMCE help

Reported by: azaozz Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit
Focuses: Cc:

Description

The content of the "Help" modal in TinyMCE needs updating. Some buttons have changed in 4.0 and it should probably have an "Accessibility" tab or section.

Attachments (4)

27100.diff (2.1 KB) - added by azaozz 16 months ago.
Patch by kovshenin moved from #24067
27100.patch (2.2 KB) - added by chiragswadia 14 months ago.
Corrections required
27100.1.patch (10.2 KB) - added by azaozz 14 months ago.
27100.2.diff (8.3 KB) - added by nacin 14 months ago.

Download all attachments as: .zip

Change History (20)

@azaozz16 months ago

Patch by kovshenin moved from #24067

comment:1 @azaozz16 months ago

Perhaps there should be "What's new" section too. There are some styling changes for the more and nextpage tags and for editing images, more to come.

comment:2 @ircbot15 months ago

This ticket was mentioned in IRC in #wordpress-ui by azaozz. View the logs.

comment:3 @Hanni15 months ago

Noting that https://core.trac.wordpress.org/ticket/27160#comment:6 should possibly be considered, too.

What's new is a bit ephemeral for the help text, perhaps, when one considers the burden with regards to translations etc.

comment:4 @ocean9015 months ago

  • Type changed from enhancement to task (blessed)

comment:5 @ircbot15 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

comment:6 @nacin14 months ago

  • Keywords needs-patch added

27100.diff looks good but we should explain that Paste from Word happens automatically, versus that Paste from Text should be used (which isn't entirely true).

comment:7 @chiragswadia14 months ago

Made suitable corrections as pointed out by @nacin

@chiragswadia14 months ago

Corrections required

comment:8 @chiragswadia14 months ago

  • Keywords has-patch added; needs-patch removed

comment:9 @ocean9014 months ago

  • Keywords commit added

comment:10 @ocean9014 months ago

In 27972:

Update TinyMCE help for pasting content.

props chiragswadia.
see #27100.

@azaozz14 months ago

comment:11 @azaozz14 months ago

In 27100.1.patch, editor help modal:

  • Don't load the old tiny_mce_popup.js.
  • List the shortcut for <code> and the second shortcut for link.
  • Update some of the text.

comment:12 @azaozz14 months ago

In 28027:

TinyMCE help modal:

  • Don't load the old tiny_mce_popup.js.
  • Add the shortcut for <code> and the second shortcut for link to the shortcuts listing.
  • Update some of the text.

See #27100

comment:13 @nacin14 months ago

In 28028:

TinyMCE help: Break up strings changed in [28027] for ease of changing later.

Restores a not inaccurate paragraph to reduce churn.

see #27100.

@nacin14 months ago

comment:14 @nacin14 months ago

Had a conversation with Siobhan. After reviewing the WordPress help tab content, it was clear that this TinyMCE help dialog content was duplicative and inferior. Everything here is already covered by the "Title and Post Editor" and "Inserting Media" tabs. So let's just axe the whole thing. The only thing that's useful here is the hotkeys, so let's rebrand the button as "Keyboard Shortcuts".

Patch attached as 27100.2.diff. Any issues?

Ideally, this keyboard shortcuts dialog is a more complete, proper overlay like Gmail or Twitter (rather than be narrow and require scrolling). But this is fine for 3.9. We can give it a proper design in a future release and maybe even bring the same thing to the comments screen. Note for Gmail and Twitter you can use the shortcut ? (shift + /). We should absolutely adopt that for both screens too.

comment:15 @ircbot14 months ago

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.

comment:16 @nacin14 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28032:

Nuke the TinyMCE help dialog as it is duplicated by help tabs. This leaves just Keyboard Shortcuts.

fixes #27100.

Note: See TracTickets for help on using tickets.