WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27739 closed defect (bug) (fixed)

Load the minified TinyMCE in production

Reported by: azaozz Owned by: azaozz
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: TinyMCE Keywords: commit has-patch
Focuses: Cc:

Description

Currently we load tinymce.js (non-minified) when running from /src and when we detect compression issues or SCRIPT_DEBUG is enabled in /build. This is quite handy for debugging all editor related code.

For the release (production) we will have to exclude tinymce.js (950KB) and switch to loading tinymce.min.js. It would be nice to keep the non-minified version and load it only when running from /src.

Attachments (3)

27739.patch (3.3 KB) - added by azaozz 6 years ago.
27739.2.patch (3.3 KB) - added by azaozz 6 years ago.
27739.diff (2.0 KB) - added by nacin 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @azaozz
6 years ago

This ticket is mostly a reminder to start loading tinymce.min.js and stop copying tinymce.js to /build before release.

@azaozz
6 years ago

#2 @azaozz
6 years ago

In 27739.patch: load tinymce.js when running from /src, else load tinymce.min.js or wp-tinymce.js.gz. Also fixes and cleans up wp-tinymce.php.

#3 @azaozz
6 years ago

  • Keywords commit has-patch added

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


6 years ago

@azaozz
6 years ago

#5 @azaozz
6 years ago

In 27739.2.patch: fix detection whether we are running from /src.

@nacin
6 years ago

#6 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 28081:

Don't include the non-minified tinymce.js in /build. Load it when running from /src, else load wp-tinymce.js.gz (production) or tinymce.min.js (SCRIPT_DEBUG). Props nacin, fixes #27739

Note: See TracTickets for help on using tickets.