WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#27847 closed defect (bug) (fixed)

WordPress 3.9 editor not show link button as pushed on images with links

Reported by: Zeokat Owned by: nacin
Milestone: 3.9.1 Priority: normal
Severity: normal Version: 3.9
Component: Editor Keywords: has-patch commit fixed-major
Focuses: Cc:
PR Number:

Description

When you add an image that links to an URL, on the editor the "link button" isn´t showed as pushed.

Since my english is not the best, i think that this image will clear things a little bit: http://imgur.com/vKkVFwa

To reproduce the bug is very easy, simply add an image from your media library and check the status of the "link button" when you select an image into the editor.

Thanks in advance for your attention.

Attachments (1)

27847.patch (754 bytes) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (10)

#1 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.9.1

Thanks for the report, Zeokat! Moving to 3.9.1 for investigation.

@azaozz
6 years ago

#2 @azaozz
6 years ago

Confirmed. This is just a visual glitch, the Link and Unlink buttons work as expected for images. 27847.patch fixes it but not sure if it should go in .1 release.

This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.


5 years ago

#4 follow-up: @iseulde
5 years ago

  • Keywords needs-patch added

Maybe related: when you make something bold inside a link, putting your cursor inside the bold text won't make the buttons active either.

#5 in reply to: ↑ 4 @azaozz
5 years ago

  • Keywords has-patch added; needs-patch removed

Replying to avryl:

The above patch fixes these cases too.

#6 @iseulde
5 years ago

Oops, somehow I missed the patch. :) Yep, it works fine!

#7 @azaozz
5 years ago

In 28185:

TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected, see #27847, for trunk.

#8 @nacin
5 years ago

  • Keywords commit fixed-major added

#9 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 28232:

TinyMCE: fix the "active" state of the Link button when an image wrapped in a link is selected.

Merges [28185] to the 3.9 branch.

props azaozz.
fixes #27847.

Note: See TracTickets for help on using tickets.