Arrow in "Continue reading" text should be preceded by a non-breaking space

[CRCulver]

When [more] is used, the text "Continue reading →" appears. However, the space between "reading" and the arrow "→" is a normal space, which can cause the arrow to be separated from the words "Continue reading" and appear one line down or even further from the text, especially common when dealing with floating images. This is not typographically elegant. I am attaching a screenshot.

I suggest that this text be changed to "Continue reading →", and the HTML entity for the non-breaking space will ensure that the line remains together.

[CRCulver]

Screenshot to show inappropriate line breaking

[SergeyBiryukov]

Looks like this applies to all our bundled themes.

[dominik.schwind]

Patch for the twentyfourteen theme.

[dominik.schwind]

Okay, I've added a patch for the twentyfourteen theme. (Hello, from the WordCamp in Zürich!)

This will mess up all the translations, though.

[dominik.schwind]

The pot-file was missing in the original patch.

[dominik.schwind]

Patch for the twentythirteen theme.

[ocean90]

Hello Dominik,

thanks for your patch. There is no need to patch the .pot files because they are auto-generated by our potbot (which is currently nacin. :))

[dominik.schwind]

Replying to ocean90:

Good to know. :) I'll patch ten to twelve, too.

[dominik.schwind]

Patch for the twentytwelve theme.

[dominik.schwind]

Patch for the twentyeleven theme.

[dominik.schwind]

Patch for the twentyten theme.

[SergeyBiryukov]

I wonder if we could patch get_the_content() instead, so that all themes (not just bundled ones) would benefit from this without breaking existing translations.

See 27908.patch​, which replaces regular spaces with   outside of HTML tags.

[dominik.schwind]

Replying to SergeyBiryukov:

I wonder if we could patch get_the_content() instead, so that all themes (not just bundled ones) would benefit from this without breaking existing translations.

Yes, that's probably the cleaner way of doing it.

[miqrogroove]

This seems like more of a style bug to me. Why do we have to change the text?

[SergeyBiryukov]

Indeed, .more-link { white-space: nowrap; } would resolve this for a particular theme.

Should we perhaps make it a suggestion in ​theme review guidelines?

[grapplerulrich]

@SergeyBiryukov The official guidlines are here: ​http://make.wordpress.org/themes/guidelines/

[DrewAPicture]

27908.patch​ still applies. Seems like the cleaner solution. Moving for commit consideration.

[obenland]

I think CSS would be the more elegant route. And in light of avoiding default styles recently (HTML5 galleries and captions, and such), I'm leaning towards letting themes handle it.

[obenland]

The more I think about it, the stronger I feel about it being something a theme should address.
We don't filter the_title() to prevent orphans either.

[SergeyBiryukov]

Should we address it in bundled themes then?

[obenland]

Yes, let's go with your suggestion.

[DustinHartzler]

Added .more-link { white-space: nowrap; } to twentyfourteen and twentythirteen themes in 27908.diff

[SergeyBiryukov]

27908.diff​ is a good start, but it only applies to print styles.

27908.2.diff​ should cover this for all the bundled themes.

[SergeyBiryukov]

In 29771:

Bundled themes: Prevent the arrow in "Continue reading" links from wrapping to a second line.

props DustinHartzler, dominik.schwind.
fixes #27908.