Make WordPress Core

Opened 16 years ago

Last modified 3 years ago

#2877 reopened defect (bug)

A Slash too much @ get_pagenum_link()

Reported by: davemad-davenet's profile dave@… Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.0
Component: Posts, Post Types Keywords: has-patch needs-testing
Focuses: template Cc:


  • File: template-functions-links.php
  • Function: get_pagenum_link()

The following code is at the end of the function:

	// showing /page/1/ or ?paged=1 is redundant
	if ( 1 === $pagenum ) {
		$qstr = str_replace('page/1/', '', $qstr); // for mod_rewrite style
		$qstr = remove_query_arg('paged', $qstr); // for query style

If you work with the mod_rewrite style, you will get this URL for the first page:
This wont work (/ at the end).


	// showing /page/1/ or ?paged=1 is redundant
	if ( 1 === $pagenum ) {
		$qstr = str_replace('/page/1/', '', $qstr); // for mod_rewrite style
		$qstr = remove_query_arg('paged', $qstr); // for query style


  • sry for my bad english...
  • i've downloaded a german translation of wordpress 2.0.3, so maybe its just in this version... ?!

Attachments (3)

2877.diff (1.4 KB) - added by scribu 11 years ago.
2877.2.diff (1.4 KB) - added by jesin 7 years ago.
Refresh 2877.diff
2877-test.diff (891 bytes) - added by jesin 7 years ago.

Download all attachments as: .zip

Change History (14)

#1 @darkfate
16 years ago

No, it's that way in the english version. I don't think that would fix it and there would be a problem with that. Putting the slash in front like you did would make the server redirect to root. So if you have wordpress in a directory it would screw up like so:
You would want this:
But you would get this:

#2 @Nazgul
15 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

No traction in almost a year, so closing as wontfix.

Feel free to re-open it if you have additional information/suggestions/patches/...

#3 @scribu
11 years ago

  • Keywords needs-patch added
  • Milestone set to Future Release
  • Resolution wontfix deleted
  • Status changed from closed to reopened

Only enhancements or feature requests can be closed when there's no traction.

11 years ago

#4 @scribu
11 years ago

  • Keywords has-patch added; needs-patch removed

#5 @scribu
11 years ago

Note that the problem is with first-page links, not with /page/2, /page/3/ etc.

Original thread:

Last edited 11 years ago by scribu (previous) (diff)

#6 @nacin
8 years ago

  • Component changed from General to Template

Interesting patch.

#7 @nacin
8 years ago

  • Keywords needs-unit-tests added

#8 @nacin
8 years ago

  • Component changed from Template to Posts, Post Types
  • Focuses template added

#9 @obenland
8 years ago

  • Keywords needs-refresh added

#10 @chriscct7
7 years ago

  • Version changed from 2.0.3 to 2.0

7 years ago

Refresh 2877.diff

7 years ago

#11 @mattheweppelsheimer
3 years ago

  • Keywords needs-testing added; needs-unit-tests needs-refresh removed
Note: See TracTickets for help on using tickets.