Opened 16 years ago
Last modified 3 years ago
#2877 reopened defect (bug)
A Slash too much @ get_pagenum_link()
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | 2.0 |
Component: | Posts, Post Types | Keywords: | has-patch needs-testing |
Focuses: | template | Cc: |
Description
- File: template-functions-links.php
- Function: get_pagenum_link()
The following code is at the end of the function:
// showing /page/1/ or ?paged=1 is redundant if ( 1 === $pagenum ) { $qstr = str_replace('page/1/', '', $qstr); // for mod_rewrite style $qstr = remove_query_arg('paged', $qstr); // for query style }
If you work with the mod_rewrite style, you will get this URL for the first page:
http://www.example.com/wordpress/index.php/
This wont work (/ at the end).
Correx:
// showing /page/1/ or ?paged=1 is redundant if ( 1 === $pagenum ) { $qstr = str_replace('/page/1/', '', $qstr); // for mod_rewrite style $qstr = remove_query_arg('paged', $qstr); // for query style }
Notes:
- sry for my bad english...
- i've downloaded a german translation of wordpress 2.0.3, so maybe its just in this version... ?!
Attachments (3)
Change History (14)
#2
@
15 years ago
- Resolution set to wontfix
- Status changed from new to closed
No traction in almost a year, so closing as wontfix.
Feel free to re-open it if you have additional information/suggestions/patches/...
#3
@
11 years ago
- Keywords needs-patch added
- Milestone set to Future Release
- Resolution wontfix deleted
- Status changed from closed to reopened
Only enhancements or feature requests can be closed when there's no traction.
#5
@
11 years ago
Note that the problem is with first-page links, not with /page/2, /page/3/ etc.
Original thread: http://wordpress.org/support/topic/plugin-wp-pagenavi-trailing-slash-at-first-page-url-regardless-of-defined-permalink-structure
Note: See
TracTickets for help on using
tickets.
No, it's that way in the english version. I don't think that would fix it and there would be a problem with that. Putting the slash in front like you did would make the server redirect to root. So if you have wordpress in a directory it would screw up like so:
You would want this:
http://site.com/wordpress/testing/1/
But you would get this:
http://site.com/testing/1/