A Slash too much @ get_pagenum_link()

[dave@…]

• File: template-functions-links.php
• Function: get_pagenum_link()

The following code is at the end of the function:

	// showing /page/1/ or ?paged=1 is redundant
	if ( 1 === $pagenum ) {
		$qstr = str_replace('page/1/', '', $qstr); // for mod_rewrite style
		$qstr = remove_query_arg('paged', $qstr); // for query style
	}

If you work with the mod_rewrite style, you will get this URL for the first page:

​http://www.example.com/wordpress/index.php/
This wont work (/ at the end).

Correx:

	// showing /page/1/ or ?paged=1 is redundant
	if ( 1 === $pagenum ) {
		$qstr = str_replace('/page/1/', '', $qstr); // for mod_rewrite style
		$qstr = remove_query_arg('paged', $qstr); // for query style
	}

Notes:

• sry for my bad english...
• i've downloaded a german translation of wordpress 2.0.3, so maybe its just in this version... ?!

[darkfate]

No, it's that way in the english version. I don't think that would fix it and there would be a problem with that. Putting the slash in front like you did would make the server redirect to root. So if you have wordpress in a directory it would screw up like so:
You would want this:
​http://site.com/wordpress/testing/1/
But you would get this:
​http://site.com/testing/1/

[Nazgul]

No traction in almost a year, so closing as wontfix.

Feel free to re-open it if you have additional information/suggestions/patches/...

[scribu]

Only enhancements or feature requests can be closed when there's no traction.

[scribu]

Note that the problem is with first-page links, not with /page/2, /page/3/ etc.

Original thread: ​http://wordpress.org/support/topic/plugin-wp-pagenavi-trailing-slash-at-first-page-url-regardless-of-defined-permalink-structure

[nacin]

Interesting patch.

[jesin]

Refresh 2877.diff

[audrasjb]

We discussed this issue during this week Old Tickets Triage Session.

The patch needs to be refreshed. Assigning @petitphp who's willing to add a new patch/unit tests.

Thanks to @SergeyBiryukov, @maigret, @petitphp for discussing this issue :)

Trac ticket: https://core.trac.wordpress.org/ticket/2877

[petitphp]

PR with refreshed patch added.

I've made a change from the original patch to ensure query_args don't force a trailing slash, and I updated the tests accordingly.

I've tested multiple cases :

• single site install with permalink structure /%category%/%postname%/ (trailing slash)
  • link to first page : ​https://example.com/category/nam-voluptas/
  • link to second page : ​https://example.com/category/nam-voluptas/page/2/
• single site install with permalink structure /%category%/%postname% (no trailing slash)
  • link to first page : ​https://example.com/category/officiis-incidunt
  • link to second page : ​https://example.com/category/officiis-incidunt/page/2
• multisite subdirectory install with permalink structure /%category%/%postname%
  • link to first page : ​https://example.com/site-one/category/quia-voluptatem
  • link to second page : ​https://example.com/site-one/category/quia-voluptatem/page/2
• multisite subdomain install with permalink structure /%category%/%postname%
  • link to first page : ​https://site-one.example.com/category/quasi
  • link to second page : ​https://site-one.example.com/category/quasi/page/2

In every case, get_pagenum_link correctly matched the permalink structure and only added a trailing slash if present.

This should be ready for testing on more exotic WordPress install.

[audrasjb]

Thanks for the PR @petitphp!
Moving for 6.3 consideration.

[mukesh27]

This ticket was discussed in the recent bug scrub.

The PR looks good and requires manual testing. Could someone from the testing team, such as @ironprogrammer or @webtechpooja, please review it?

Additional props to @oglekler