WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#28868 closed enhancement (wontfix)

Remove unused media.view.ButtonGroup

Reported by: ericlewis's profile ericlewis Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: 2nd-opinion has-patch
Focuses: javascript Cc:

Description

media.view.ButtonGroup isn't used anywhere. Let's get rid of it.

Attachments (1)

28868.diff​ (1.2 KB) - added by ericlewis 11 years ago.

Download all attachments as: .zip

Change History (6)

@ericlewis
11 years ago

#1 follow-up: @nacin
10 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to Future Release

I see this in 3.5, but it looks like this may well have never been used. I'm OK with removing it, but could someone else have found this and decided to use it?

If we're going to remove it, it needs to happen early in a cycle.

#2 @MikeHansenMe
10 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
10 years ago

  • Version changed from 4.0 to 3.5

#4 in reply to: ↑ 1 @ericlewis
10 years ago

Replying to nacin:

could someone else have found this and decided to use it?

This is a good point - we should probably just deprecate.

#5 @wonderboymusic
10 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Let's just leave it. If it breaks ANYWHERE, we'll end up adding it back. It's in its own module now.

Note: See TracTickets for help on using tickets.