Opened 11 years ago
Closed 11 years ago
#28884 closed defect (bug) (fixed)
No review stars in plugin details popup in 4.0
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Plugins | Keywords: | |
Focuses: | administration | Cc: |
Description
I'm not sure if there is a reason behind it, but I can't see any stars rating in the review tab of the new plugin details lightbox.
4th ticket of the day :) Sorry for that...
Attachments (6)
Change History (23)
This ticket was mentioned in IRC in #wordpress-dev by celloexpressions. View the logs.
11 years ago
#3
@
11 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 4.0
Not sure if this is doable with the .org API, but I don't think we should display reviews without their ratings. May need to consider removing the reviews tab entirely if we can't fix it.
#4
@
11 years ago
- Keywords has-patch added; needs-patch removed
I couldn't find where the API shows individual review rating so added a quick patch to hide the ratings tab. If someone is more familiar with the Plugin API then showing the individual ratings is preferred.
#5
@
11 years ago
Version 2 of the patch fully removed the Reviews code not just hides the tab. I was missing the if statement in the output.
#6
@
11 years ago
- Focuses administration added
- Keywords needs-patch added; has-patch removed
We're not going to remove the reviews tab. API changes are requested.
#7
@
11 years ago
The ratings markup is being added but then stripped by kses on the API side. Working on that.
#8
@
11 years ago
Are there any concerns with allowing those additional tags?
I'm open to other minor improvements to the reviews layout too, especially if it can be done without further core patches. That would be easier with the allowed_tags patch, since it allows divs.
This ticket was mentioned in IRC in #wordpress-dev by tellywor_. View the logs.
11 years ago
#10
@
11 years ago
A little bit related, but judging from the above screenshot it's really hard to discern which stars belong to which review. I think some separation is needed for each review such as a <hr> line and some spacing.
#14
follow-up:
↓ 15
@
11 years ago
tellyworth, are the changes already deployed? Still can't see the review stars.
#15
in reply to:
↑ 14
@
11 years ago
Replying to ocean90:
tellyworth, are the changes already deployed? Still can't see the review stars.
API changes are deployed, yes. Is it a particular plugin where you can't see the stars?
#16
@
11 years ago
I think we should try to use the same layout as we have on .org, see 28884.dotorg.png.
Current markup for the review header:
<div class="reviewer-info"> <div class="review-title-section"> <h4>{{title}}</h4> <div class="star-rating"> <span class="screen-reader-text">1.0 rating</span> <div class="star star-full"></div> <div class="star star-empty"></div> <div class="star star-empty"></div> <div class="star star-empty"></div> <div class="star star-empty"></div> </div> </div> <p> By <a href="{{url}}" target="_blank"><img alt="" src="{{gravatar}}" class="photo avatar avatar-16"></a> <a href={{url}}" target="_blank">{{name}}</a>, <span class="review-date">{{date}}</span> </p> </div>
.org markup for the review header:
<div class="review-head"> <div class="reviewer-avatar"> <a href="{{url}}"><img alt="" src="{{gravatar}}" class="photo avatar avatar-36" style="height:36px; width:36px;"></a> </div> <div class="reviewer-info"> <div class="review-title-section"> <div class="review-stars star-holder"> <div class="star-holder"> <div class="star-rating" style="width: 18.4px">1 star</div> </div> </div> <div class="review-title" itemprop="name">{{title}}</div> </div> <div class="reviewer"> By <a href="{{url}" class="reviewer-name" itemprop="author">{{name}}</a>, <span class="review-date">{{date}}</span> </div> </div> </div>
I think it's enough to change the order of title and rating in the markup, so first rating, then title.
Anyone checking this out? ;/