No review stars in plugin details popup in 4.0

[hardeepasrani]

I'm not sure if there is a reason behind it, but I can't see any stars rating in the review tab of the new plugin details lightbox.

4th ticket of the day :) Sorry for that...

[hardeepasrani]

Anyone checking this out? ;/

[celloexpressions]

Not sure if this is doable with the .org API, but I don't think we should display reviews without their ratings. May need to consider removing the reviews tab entirely if we can't fix it.

[BandonRandon]

Patch to hide the reviews tab

[BandonRandon]

I couldn't find where the API shows individual review rating so added a quick patch to hide the ratings tab. If someone is more familiar with the Plugin API then showing the individual ratings is preferred.

[BandonRandon]

Fully removes the reviews tab

[BandonRandon]

Version 2 of the patch fully removed the Reviews code not just hides the tab. I was missing the if statement in the output.

[ocean90]

We're not going to remove the reviews tab. API changes are requested.

[tellyworth]

The ratings markup is being added but then stripped by kses on the API side. Working on that.

[tellyworth]

Screenshot with fixed markup from the API; core patch needed to allow div/span

[tellyworth]

Allow div/span with class

[tellyworth]

Are there any concerns with allowing those additional tags?

I'm open to other minor improvements to the reviews layout too, especially if it can be done without further core patches. That would be easier with the allowed_tags patch, since it allows divs.

[paulwilde]

A little bit related, but judging from the above screenshot it's really hard to discern which stars belong to which review. I think some separation is needed for each review such as a <hr> line and some spacing.

[SergeyBiryukov]

In 29511:

• Add span to the list of allowed tags in plugin sections in plugin details modal.
• Don't strip class attribute from div/span tags in plugin sections.

props tellyworth.
see #28884.

[nacin]

[29511] looks good to me.

[hardeepasrani]

Amazing work guys!!! Time to mark it as fixed?

[ocean90]

tellyworth, are the changes already deployed? Still can't see the review stars.

[tellyworth]

Replying to ocean90:

tellyworth, are the changes already deployed? Still can't see the review stars.

API changes are deployed, yes. Is it a particular plugin where you can't see the stars?

[ocean90]

I think we should try to use the same layout as we have on .org, see 28884.dotorg.png​.

Current markup for the review header:

<div class="reviewer-info">
	<div class="review-title-section">
		<h4>{{title}}</h4>
		<div class="star-rating">
			<span class="screen-reader-text">1.0 rating</span>
			<div class="star star-full"></div>
			<div class="star star-empty"></div>	
			<div class="star star-empty"></div>
			<div class="star star-empty"></div>
			<div class="star star-empty"></div>
		</div>
	</div>
	<p>
		By <a href="{{url}}" target="_blank"><img alt="" src="{{gravatar}}" class="photo avatar avatar-16"></a>
		<a href={{url}}" target="_blank">{{name}}</a>,
		<span class="review-date">{{date}}</span>
	</p>
</div>

.org markup for the review header:

<div class="review-head">
	<div class="reviewer-avatar">
		<a href="{{url}}"><img alt="" src="{{gravatar}}" class="photo avatar avatar-36" style="height:36px; width:36px;"></a>
	</div>
	<div class="reviewer-info">
		<div class="review-title-section">
			<div class="review-stars star-holder">
				<div class="star-holder">
					<div class="star-rating" style="width: 18.4px">1 star</div>
				</div>
			</div>
			<div class="review-title" itemprop="name">{{title}}</div>
		</div>
		<div class="reviewer">
			By <a href="{{url}" class="reviewer-name" itemprop="author">{{name}}</a>,
			<span class="review-date">{{date}}</span>
		</div>
	</div>
</div>

I think it's enough to change the order of title and rating in the markup, so first rating, then title.

[ocean90]

Closing as fixed, since the rating stars are now available.

For styling we have #29321.