WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 2 years ago

#28908 new defect (bug)

Adding a menu custom link during autocompletion does not add the full text in firefox

Reported by: Nessworthy Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch dev-feedback needs-testing
Focuses: administration Cc:

Description

Tested on Firefox 30.0

In Appearance => Menus, creating a menu and adding custom links does not save the full link text under the condition that you have selected an auto complete value and hit the enter key.

Presumably, the auto complete value should be inserted, then the field should be saved with that value.

Entering:
http://s.nessworthy.me/2014071509500201.png

Submitting/Saving (via enter key):
http://s.nessworthy.me/20140715095111549.png

Result:
http://s.nessworthy.me/20140715095033870.png

This applies to both the link URL and the link name. Didn't add the link URL screenshots to save screen space.

Attachments (1)

28908.1.diff (678 bytes) - added by Nessworthy 3 years ago.
First pass in an attempt to fix firefox's autocomplete bug affecting adding custom menu links. The patch was based on the answer of the linked StackOverflow question: http://stackoverflow.com/questions/2303955/i-have-a-problem-with-keydown-event-and-autocomplete-in-firebox-on-mac

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
4 years ago

  • Component changed from Administration to Menus

#2 @celloexpressions
3 years ago

  • Focuses ui javascript removed
  • Version changed from trunk to 3.0

I think I've seen this in Chrome before too.

#3 @Nessworthy
3 years ago

Issue seems to be due to a Firefox known bug regarding the timing / order of FF's autocomplete internal workings and the keypress event.

The bug is discussed from the perspective of the browser in BugZilla ticket 286933 at https://bugzilla.mozilla.org/show_bug.cgi?id=286933

@Nessworthy
3 years ago

First pass in an attempt to fix firefox's autocomplete bug affecting adding custom menu links. The patch was based on the answer of the linked StackOverflow question: http://stackoverflow.com/questions/2303955/i-have-a-problem-with-keydown-event-and-autocomplete-in-firebox-on-mac

#4 @Nessworthy
3 years ago

  • Keywords has-patch added

I figure that this should be discussed before considering any patches, but the workaround is simple enough to prepare just in case.

It's clear that this issue is still in discussion in BugZilla, and whether to go ahead and add the autocompleted text into the field before user scripts are triggered is only one possible option discussed.

This is an issue that has been in talks for 9 years; I don't think any headway is going to be made on it any time soon.

#5 @Nessworthy
3 years ago

  • Keywords dev-feedback added

#6 @joedolson
3 years ago

  • Focuses accessibility removed

#7 @chriscct7
2 years ago

  • Keywords needs-testing added
Note: See TracTickets for help on using tickets.