WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#29110 closed enhancement (fixed)

Update MediaElement to 2.15.0

Reported by: wonderboymusic's profile wonderboymusic Owned by: ocean90's profile ocean90
Milestone: 4.0 Priority: high
Severity: normal Version: 4.0
Component: External Libraries Keywords: has-patch
Focuses: javascript Cc:

Description

​https://github.com/johndyer/mediaelement/compare/2.14.2...master

Attachments (2)

29110.diff​ (230.3 KB) - added by wonderboymusic 10 years ago.
29110.2.diff​ (8.9 KB) - added by wonderboymusic 10 years ago.

Download all attachments as: .zip

Change History (27)

@wonderboymusic
10 years ago

#1 @wonderboymusic
10 years ago

In 29429:

MediaElement upgrade: cleanup for generated markup for videos.

See #29110.

#2 @wonderboymusic
10 years ago

Chromeless YouTube is not working for me... - audio plays, video does not. Seems to be another weird dimensions issue.

#3 @wonderboymusic
10 years ago

In 29430:

Video: use auto instead of actual height for the responsive wrapper in generated markup.

See #29110.

#4 @wonderboymusic
10 years ago

I need to do some more testing before upgrading MEjs code. Some weird stuff happening locally for me.

#5 @wonderboymusic
10 years ago

In 29456:

Video:

  • Don't set height on responsive <div> when generating markup
  • Move some CSS rules from the style tag to .wp-video
  • Use Video Details view event delegation instead of click events delegated from <body>
  • Fix some CSS rule collision in the grid modal

See #29110.

#6 @wonderboymusic
10 years ago

In 29457:

Upgrade MediaElement to 2.15.0:

All changes:
​https://github.com/johndyer/mediaelement/compare/2.14.2...master

See #29110.

#7 @wonderboymusic
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#8 @ocean90
10 years ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

This brokes a unit test: Tests_Media::test_video_shortcode_body

#9 @ocean90
10 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from reopened to closed

In 29515:

Fix expected value in Tests_Media::test_video_shortcode_body().
Since [29457] the .wp-video wrapper for a video has a height set.

fixes #29110.

#10 @programmin
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I'm seeing completely broken wp-video and audio with Chromium 37, 2014 theme, 4.0 from SVN, with a simple audio or video shortcode. Replacing wp-includes/js/mediaelement/mediaelement-and-player.min.js with the 2.14.2 version fixes it.

#11 @wonderboymusic
10 years ago

What type of files?

#12 @programmin
10 years ago

Mp4, mp3, maybe others? Works in Firefox on Ubuntu but not Chromium.

#13 @wonderboymusic
10 years ago

any JS errors in the logs?

#14 @programmin
10 years ago

Unfortunately no JS errors at all, I'll try to debug into this a bit...

#16 @programmin
10 years ago

I just compared debugging through in Chromium and Chrome, and it looks like 2.15 is specifically breaking Chromium here, only allowing it to play ogg audio/video.

        if (mejs.MediaFeatures.isChromium)
            a.canPlayType = function(m) {
                return m.match(/video\/(webm|ogv|ogg)/gi) !== null ? "maybe" : 
                ""
            };

I notified the developer, it looks like this is the bug that introduced it: ​https://github.com/johndyer/mediaelement/pull/1020

Please consider patching this for Chromium users.

#17 @nacin
10 years ago

  • Priority changed from normal to high

I would consider reverting that upstream commit to maintain the status quo for WP 4.0, and then considering it again in the future once it's been reviewed upstream.

This ticket was mentioned in IRC in #wordpress-dev by nacin. ​View the logs.
10 years ago

@wonderboymusic
10 years ago

#19 @wonderboymusic
10 years ago

  • Keywords has-patch added; needs-patch removed

@programmin, can you try:
https://core.trac.wordpress.org/attachment/ticket/29110/29110.2.diff

Reverts the PR related to Chromium

#20 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29688:

MediaElement: Revert upstream commit b7f82b4 to restore the status quo for Chromium support.

fixes #29110.

#21 @nacin
10 years ago

In 29689:

MediaElement: Bump version. see #29110.

#22 @programmin
10 years ago

Once again MeJS is breaking in Chromium in WP4.1 beta. (Chromium 39 on Ubuntu, to be specific.) Was the fix reverted?

Last edited 10 years ago by programmin (previous) (diff)

#23 @wonderboymusic
10 years ago

I will re-add the fix

#24 @programmin
8 years ago

I just saw that this is still happening on wp4.7.1 when on Chromium. Was the fix reverted again?

#25 @programmin
8 years ago

The issue persists in 4.7.3.

If you don't do "mejs.MediaFeatures.isChromium = false" the mp3 breaks and just shows "download file" in player on Chromium, which is most likely the version most Ubuntu Chrome users will be using.

Last edited 8 years ago by programmin (previous) (diff)
Note: See TracTickets for help on using tickets.