WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#29212 closed defect (bug) (wontfix)

Distraction-free Writing: hide Add Media button for users without `upload_files` capability

Reported by: lancewillett Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: ui Cc:

Description

Similar to #28327, contributor users should not be able to see the "Add Media" button in Distraction Free Writing.

It causes user confusion because they can see the button, load the Media Library view, but cannot upload or use existing images.

To repeat:

  1. Log in as a contributor user.
  2. Edit a post (or start a new post)
  3. Switch to Distraction Free Writing mode
  4. View the "Add New Media" button in the editor tools

Screenshots and a screencast attached.

Attachments (4)

button-is-visible.png (50.2 KB) - added by lancewillett 6 years ago.
error-after-trying-upload.png (125.3 KB) - added by lancewillett 6 years ago.
contributor-upload-dfw.gif (539.1 KB) - added by lancewillett 6 years ago.
29212.patch (500 bytes) - added by lancewillett 6 years ago.

Download all attachments as: .zip

Change History (8)

@lancewillett
6 years ago

#1 @stephdau
6 years ago

Tested patch on RC2/trunk, works as advertised.

This ticket was mentioned in IRC in #wordpress-dev by stephdau. View the logs.


6 years ago

#3 @SergeyBiryukov
6 years ago

  • Keywords 4.1-early added
  • Milestone changed from Awaiting Review to Future Release

#4 @iseulde
6 years ago

  • Keywords 4.1-early removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

DFW mode has changed in 4.1.

Note: See TracTickets for help on using tickets.