Plugin Install: "x stars" is not translatable

[ocean90]

See trunk/src/wp-admin/includes/plugin-install.php#L460​

[jesin]

Patch 29220.diff uses _n() which prints 1 star instead of 1 stars as it appears in WP.org. Should I use __() instead?

[ocean90]

Replying to jesin:
Haven't thought about using _n() here, but that's the correct one in this case. There is only one small visual issue now, see ​https://cloudup.com/cMOS9_EGsqH. Seems like we have to use some sort of min-width here.

And while we are here, $ratecount should use number_format_i18n().

[jesin]

"x stars" translatable, min-width for .counter-label and $ratecount uses number_format_i18n()

[jesin]

I think the alignment is perfect now.

[ocean90]

In 29510:

Plugin details: Use translation functions.

props jesin.
fixes #29220.

[danielbachhuber]

Does printf( _n( '%d star', '%d stars', $key ), $key ); need to be escaped?

[SergeyBiryukov]

Translated strings are considered safe, we generally only escape them when used in attributes.

$key comes directly from the API, so [29510] looks good to me as is.