Opened 10 years ago
Closed 10 years ago
#29349 closed defect (bug) (fixed)
Post metaboxes jump when you hit the bottom of the page
Reported by: | melchoyce | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | ui, administration | Cc: |
Description (last modified by )
See this video: https://cloudup.com/cBpjxUro7_x
(Also attaching the video, just in case)
Tested on OSX Chrome.
Attachments (2)
Change History (10)
#3
@
10 years ago
So the problem is:
- the bottom of the sidebar is pinned, with a "max-bottom" of 180px: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/editor-expand.js?rev=29628#L470
- but when one scrolls passed the doc's bottom edge with elastic scrolling, we re-enter the " let it scroll" mode, with an "auto max-bottom": https://core.trac.wordpress.org/browser/trunk/src/wp-admin/js/editor-expand.js?rev=29628#L444
This ticket was mentioned in IRC in #wordpress-dev by stephdau. View the logs.
10 years ago
#5
@
10 years ago
- Keywords has-patch commit added
- Milestone changed from Awaiting Review to 4.0
29349.patch fixes it here. Also adds a var for the 'bottom' distance and fixes pinning of the sidebar when the height is nearly the same as the viewport height.
This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.
10 years ago
Note: See
TracTickets for help on using
tickets.
Stating the obvious: that because of the bottom-pinning brought in b4 vs Chrome's elastic scrolling.
I think we can solve that with somewhat of a max-bottom based on the document's bottom edge.
The value will need to be calculated live, since the page's total height can change via user interactions (auto-expanding editor, meta box drag-n-drop between columns, tag adds, etc).
Looking into a patch.