Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#29349 closed defect (bug) (fixed)

Post metaboxes jump when you hit the bottom of the page

Reported by: melchoyce's profile melchoyce Owned by: azaozz's profile azaozz
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Administration Keywords: has-patch commit
Focuses: ui, administration Cc:

Description (last modified by melchoyce)

See this video: https://cloudup.com/cBpjxUro7_x

(Also attaching the video, just in case)

Tested on OSX Chrome.

Attachments (2)

boing.mp4 (1.5 MB) - added by melchoyce 10 years ago.
29349.patch (3.6 KB) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (10)

@melchoyce
10 years ago

#1 @melchoyce
10 years ago

  • Description modified (diff)

#2 @stephdau
10 years ago

Stating the obvious: that because of the bottom-pinning brought in b4 vs Chrome's elastic scrolling.
I think we can solve that with somewhat of a max-bottom based on the document's bottom edge.
The value will need to be calculated live, since the page's total height can change via user interactions (auto-expanding editor, meta box drag-n-drop between columns, tag adds, etc).

Looking into a patch.

#3 @stephdau
10 years ago

So the problem is:

Last edited 10 years ago by stephdau (previous) (diff)

This ticket was mentioned in IRC in #wordpress-dev by stephdau. View the logs.


10 years ago

@azaozz
10 years ago

#5 @azaozz
10 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.0

29349.patch fixes it here. Also adds a var for the 'bottom' distance and fixes pinning of the sidebar when the height is nearly the same as the viewport height.

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.


10 years ago

#7 @nacin
10 years ago

Go for it.

#8 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 29656:

Editor expand:

  • Adjust calculation when comparing sidebar position to wpfooter top. Fixes an annoying jumping when the user scrolls off the bottom.
  • Use a var for the 'bottom' distance of the sidebar.
  • Fix sidebar pinning when it's height is nearly the same as the viewport height.

Fixes #29349

Note: See TracTickets for help on using tickets.