WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 months ago

#29385 closed defect (bug) (wontfix)

wpview: selecting all the content with ctrl/cmd + A when there's a view on top doesn't work

Reported by: iseulde Owned by: iseulde
Milestone: Priority: normal
Severity: trivial Version: 4.0
Component: TinyMCE Keywords: has-patch
Focuses: javascript Cc:
PR Number:

Description


Attachments (1)

29385.patch (1.2 KB) - added by iseulde 5 years ago.

Download all attachments as: .zip

Change History (9)

@iseulde
5 years ago

#1 @iseulde
5 years ago

  • Keywords has-patch added; needs-patch removed

The problem: event.element from the NodeChange event always gives the first element in the editor if everything is selected. If the first element is a view however, we detect that the view is not properly selected and set the cursor before the view. We could limit this to only collapsed ranges, since the chance of having a lost uncollapsed range inside a view is extremely rare.

Another issue with views at the top or bottom of the editor is that they're not correctly removed when selecting everything and then hitting backspace. For me the last view was left, and the first view was broken and not visible. We could probably fix this by detecting a full selection and then correctly removing all the content on backspace or any other keypress that inserts some content.

#2 @iseulde
5 years ago

  • Summary changed from wpview: selecting all the content with ctrl/cmd + A when there are views doesn't work to wpview: selecting all the content with ctrl/cmd + A when there's a view on top doesn't work

#3 @helen
5 years ago

  • Keywords 4.1-early added
  • Milestone changed from Awaiting Review to Future Release

#4 @iseulde
5 years ago

  • Severity changed from normal to trivial

#5 @iseulde
5 years ago

  • Keywords 4.1-early removed

#6 @wonderboymusic
4 years ago

  • Owner set to iseulde
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


3 years ago

#8 @azaozz
5 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Now superseded by the block editor.

Note: See TracTickets for help on using tickets.