More semantic filter for item labels in Walker_Nav_Menu

[danielbachhuber]

Walker_Nav_Menu has a nice nav_menu_link_attributes filter for modifying the attributes of a nav menu item. However, it applies the_title for the label of the item, and only supplies the value and the ID of the nav menu item.

This makes it difficult to target when you only want to filter the label of the item. It would be nice to have a more semantic filter which supplied the full $item and $args.

My use case: I'm adding the HTML for FontAwesome icons when certain conditions are met.

[bjornjohansen]

Added nav_menu_item_args filter

[bjornjohansen]

I added a filter, nav_menu_item_args, on the entire $args object so all the before/after/link_before/link_after properties can be modified, covering your use case. I added it before any use of $args, in case one might want to modify it for the other uses in the function as well.

[kpdesign]

Thanks for the patch bjornjohansen!

The new filter will also need ​hook documentation.

Could you add that, and submit a new patch please?

[bjornjohansen]

Replying to kpdesign:

Thanks for the patch bjornjohansen!

The new filter will also need ​hook documentation.

Could you add that, and submit a new patch please?

Thank you for the feedback, Kim. What should I use for @since? Should I be bold and set it to 4.1?

[kpdesign]

Yes, since 4.1 is the current release cycle, use @since 4.1.0 in the doc block.

[wonderboymusic]

In 34471:

Nav Menus: Add a 'nav_menu_item_args' filter to Walker_Nav_Menu::start_el().

Props bjornjohansen.
Fixes #29417.

[DrewAPicture]

The new filter doesn't have a summary or a description.

[DrewAPicture]

In 34481:

Docs: Add a summary to the hook doc for the nav_menu_item_args filter, introduced in [34471].

Fixes #29417.

[johnbillion]

This filter should receive the $depth parameter too, so it more closely matches all the other filters in this class.

[johnbillion]

In 34507:

Add $depth as a parameter in the nav_menu_item_args filter.

Fixes #29417