Editor sidebar scrolling breaks when adding anything above post meta boxes

[iseulde]

To test add some html with the submitpost_box and submitpage_box hooks.

[iseulde]

So what doesn't work is scrolling back up. It's scrolls up to the first box and then whatever's added on top scrolls under it. Until you scroll up all the way.

[AugusGils]

I had a different approach by putting any newly added content to the #side-sortables div.
I guess it's something we should decide on what's best.

[iseulde]

Replying to AugusGils:

I had a different approach by putting any newly added content to the #side-sortables div.
I guess it's something we should decide on what's best.

You're moving the action to the sortable div. So anything that action outputs will become sortable.

[AugusGils]

Only if the adder choose this by adding the right classes/html. But yea it will.

[azaozz]

29778.diff changes (a bit) how these two actions work by moving them inside the UI droppable element. This may cause incompatibilities with existing plugins. The approach in 29778.patch has full backwards compatibility.

[azaozz]

Thinking more about this: both patches are not 100% backwards compatible. The first adds another wrapper that may become a problem when a plugin traverses the parent nodes with jQuery. The second adds non-sortable elements inside UI Sortable container that may break in some cases. Not sure which one is better.

Furthermore haven't seen any bug reports about broken sidebar because of this. Would be good to test with existing plugins/code.

[noisysocks]

I tested this by adding a <p> with a large paragraph in it to submitpost_box. I wasn't able to see any issues with scrolling.

Going to close this, but happy to re-open if I've missed something.