WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#30145 closed task (blessed) (maybelater)

Introduce wp_is_trusted_network()

Reported by: jeremyfelt Owned by: jeremyfelt
Milestone: Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords:
Focuses: multisite Cc:

Description

wp_is_trusted_network() is a first step in establishing the concepts around trusted and untrusted networks in multisite as part of the potential roadmap.

At first, the function will always return false. This will allow us to start plugging it into various parts of core to better determine how to call something "open" (as in registration, with untrusted users).

In the future, it will likely default to false with a filter to modify on a per network basis.

Attachments (1)

30145.diff (487 bytes) - added by jeremyfelt 6 years ago.

Download all attachments as: .zip

Change History (12)

@jeremyfelt
6 years ago

#1 @jeremyfelt
6 years ago

  • Owner set to jeremyfelt
  • Status changed from new to assigned

#2 @jeremyfelt
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 30071:

Introduce wp_is_trusted_network()

A first step to establish concepts around trusted and untrusted networks.

  • Will always return false as default.
  • Will one day have a filter.

Fixes #30145

#3 @johnbillion
6 years ago

  • Keywords has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from enhancement to task (blessed)

Discussion points:

  • Should this be moved out of ms-functions.php?
  • Should it be renamed is_trusted_network() (minus the wp_ prefix) to match most of the other conditionals?

#4 @knutsp
6 years ago

This function must always exist, and should by default return true for single installs, and false for multisite. No more global functions without a wp_ prefix, please. is_trusted_network() may have been used already, somewhere.

Then to determine on what conditions this should return true for multisite, like a constant, or a site option.

After that we can start implementing it to make multisite go in the direction we want.

Just my humble opinion, or my two cents, if you wish.

#5 @extendwings
6 years ago

I agree with @johnbilion's 2 points.

I guess is_trusted_network() should return false in single site. Because developers can use is_multisite() to check multisite or not.

This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.


6 years ago

#7 @johnbillion
6 years ago

In 30577:

Remove the wp_is_trusted_network() function pending further discussion on terminology and behaviour.

See #30145

#8 @johnbillion
6 years ago

  • Milestone changed from 4.1 to Future Release

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


6 years ago

This ticket was mentioned in Slack in #core-multisite by saracannon. View the logs.


6 years ago

#11 @jeremyfelt
5 years ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from reopened to closed

I think we've backed off of wp_is_trusted_network() as a possible solution quite a bit. In part, this is because it's nearly impossible to define what a "trusted" network is. :)

Let's close this as a maybelater and address other things. If it makes sense in the future to have multiple network types, we can revisit.

Note: See TracTickets for help on using tickets.