Opened 10 years ago
Closed 9 years ago
#30145 closed task (blessed) (maybelater)
Introduce wp_is_trusted_network()
Reported by: | jeremyfelt | Owned by: | jeremyfelt |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | |
Focuses: | multisite | Cc: |
Description
wp_is_trusted_network()
is a first step in establishing the concepts around trusted and untrusted networks in multisite as part of the potential roadmap.
At first, the function will always return false
. This will allow us to start plugging it into various parts of core to better determine how to call something "open" (as in registration, with untrusted users).
In the future, it will likely default to false
with a filter to modify on a per network basis.
Attachments (1)
Change History (12)
#3
@
10 years ago
- Keywords has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
- Type changed from enhancement to task (blessed)
Discussion points:
- Should this be moved out of
ms-functions.php
? - Should it be renamed
is_trusted_network()
(minus thewp_
prefix) to match most of the other conditionals?
#4
@
10 years ago
This function must always exist, and should by default return true for single installs, and false for multisite. No more global functions without a wp_
prefix, please. is_trusted_network()
may have been used already, somewhere.
Then to determine on what conditions this should return true for multisite, like a constant, or a site option.
After that we can start implementing it to make multisite go in the direction we want.
Just my humble opinion, or my two cents, if you wish.
#5
@
10 years ago
I agree with @johnbilion's 2 points.
I guess is_trusted_network()
should return false
in single site. Because developers can use is_multisite()
to check multisite or not.
This ticket was mentioned in Slack in #core by jeremyfelt. View the logs.
10 years ago
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
10 years ago
This ticket was mentioned in Slack in #core-multisite by saracannon. View the logs.
10 years ago
#11
@
9 years ago
- Milestone Future Release deleted
- Resolution set to maybelater
- Status changed from reopened to closed
I think we've backed off of wp_is_trusted_network()
as a possible solution quite a bit. In part, this is because it's nearly impossible to define what a "trusted" network is. :)
Let's close this as a maybelater and address other things. If it makes sense in the future to have multiple network types, we can revisit.
In 30071: