Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#30151 closed defect (bug) (invalid)

wp-signup.php shows "We send your registration email to this address..." message even if the registration fails

Reported by: summoner's profile summoner Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.0
Component: Login and Registration Keywords:
Focuses: Cc:

Description

Hi there,

Just noticed this minor bug.
Wordpress 4.0 renders the message "We send your registration email to this address. (Double-check your email address before continuing.)" even if the registration fails for any reason.

This is because in wp-signup.php on line 191 there is no condition in the code:

<input name="user_email" type="email" id="user_email" value="<?php  echo esc_attr($user_email) ?>" maxlength="200" /><br /><?php _e('We send your registration email to this address. (Double-check your email address before continuing.)') ?>

With this slight modification it seems to be ok on my side:

<input name="user_email" type="email" id="user_email" value="<?php  echo esc_attr($user_email) ?>" maxlength="200" /><br /><?php if($errmsg) _e('We send your registration email to this address. (Double-check your email address before continuing.)') ?>

Change History (3)

#1 @summoner
10 years ago

Oh my... put the wrong conditional, sorry :-)

This is what i meant to be the solution:

<input name="user_email" type="email" id="user_email" value="<?php  echo esc_attr($user_email) ?>" maxlength="200" /><br /><?php if(!$errmsg) _e('We send your registration email to this address. (Double-check your email address before continuing.)') ?>

#2 @5um17
10 years ago

It doesn't seems like error message it is just the help text below the email field, so it should be always there even when form contains errors.

#3 @chriscct7
8 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Agreed with comment:2. Closing as invalid.

Note: See TracTickets for help on using tickets.