wp-signup.php shows "We send your registration email to this address..." message even if the registration fails

[summoner]

Hi there,

Just noticed this minor bug.
Wordpress 4.0 renders the message "We send your registration email to this address. (Double-check your email address before continuing.)" even if the registration fails for any reason.

This is because in wp-signup.php on line 191 there is no condition in the code:

<input name="user_email" type="email" id="user_email" value="<?php  echo esc_attr($user_email) ?>" maxlength="200" /><br /><?php _e('We send your registration email to this address. (Double-check your email address before continuing.)') ?>

With this slight modification it seems to be ok on my side:

<input name="user_email" type="email" id="user_email" value="<?php  echo esc_attr($user_email) ?>" maxlength="200" /><br /><?php if($errmsg) _e('We send your registration email to this address. (Double-check your email address before continuing.)') ?>

[summoner]

Oh my... put the wrong conditional, sorry :-)

This is what i meant to be the solution:

<input name="user_email" type="email" id="user_email" value="<?php  echo esc_attr($user_email) ?>" maxlength="200" /><br /><?php if(!$errmsg) _e('We send your registration email to this address. (Double-check your email address before continuing.)') ?>

[5um17]

It doesn't seems like error message it is just the help text below the email field, so it should be always there even when form contains errors.

[chriscct7]

Agreed with comment:2. Closing as invalid.