Opened 12 years ago
Closed 12 years ago
#30397 closed defect (bug) (fixed)
Slightly confusing is_email() test name
| Reported by: | dlh | Owned by: | boonebgorges |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.1 |
| Component: | Build/Test Tools | Version: | 4.1 |
| Severity: | minor | Keywords: | has-patch |
| Cc: | Focuses: |
Description
is_email() returns the string on success, not true, so test_returns_true_if_given_a_valid_email_address isn't strictly accurate.
I bring it up only after having wanted to use the is_email() tests during a demonstration as an example of a simpler unit test in core. I decided against it because I thought it might confuse someone that the test didn't use assertTrue().
Attachments (1)
Change History (5)
Note:
See TracTickets
for help on using tickets.
Yes, good call.