WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30624 closed defect (bug) (maybelater)

Malformed comment in module.audio-video.quicktime.php trips up FTP clients (solution included)

Reported by: okiru Owned by:
Milestone: Priority: normal
Severity: minor Version: 4.0.1
Component: External Libraries Keywords: has-patch
Focuses: Cc:
PR Number:

Description

/wp-includes/ID3/module.audio-video.quicktime.php in line 1377 contains a comment ("mtda keys ...") with non-printable characters. I could imagine this resulted from copypasting parts of a formatted document into a text editor that does not show (or care about) special characters.

This is worth mentioning and correcting because, when uploading via FTP, this file trips up FTP clients that check a file's content whether it's binary and compare with the file extension. For example, the FTP client in Total Commander stops in its tracks to check back with the user, whether he's really sure he wants to upload a (detected) binary file in text mode (per file extension rules). A medium-sized inconvenience with an unattended upload.

The fix is obvious.

Attachments (1)

specialchars.png (21.4 KB) - added by okiru 5 years ago.

Download all attachments as: .zip

Change History (4)

@okiru
5 years ago

#1 follow-up: @SergeyBiryukov
5 years ago

  • Component changed from General to External Libraries

This should be reported upstream: http://www.getid3.org/phpBB3/viewforum.php?f=4

#2 in reply to: ↑ 1 @okiru
5 years ago

  • Keywords has-patch added
  • Resolution set to maybelater
  • Severity changed from normal to minor
  • Status changed from new to closed

Thank you for the pointer. I fixed the file and sent a Pull Request.

#3 @ocean90
5 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.