Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30641 closed defect (bug) (fixed)

Twenty Thirteen/Fourteen: arrows in "Continue Reading" link can't be reversed for RTL

Reported by: yoavf Owned by:
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch i18n-change commit
Focuses: rtl Cc:


Since [30389], [30390] the → is no longer part of the translatable string. Previously, translators of RTL languages would have replaced it with ←

Attachments (1)

30641.diff (16.7 KB) - added by johnbillion 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @ramiy
6 years ago

Nice catch!

#2 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.1

6 years ago

#3 @johnbillion
6 years ago

  • Keywords has-patch i18n-change added; needs-patch removed

Patch. Use of esc_html__() was introduced in r30389 and r30390 but it's not really necessary. Patch replaces it with __() in order to include the markup around the arrow character.

This ticket was mentioned in Slack in #core by johnbillion. View the logs.

6 years ago

This ticket was mentioned in Slack in #core-themes by lancewillett. View the logs.

6 years ago

#6 @lancewillett
6 years ago

  • Keywords commit added

Patch looks good to commit.

#7 @davidakennedy
6 years ago

Looks good to me too. Thanks, @yoavf for catching that!

#8 @johnbillion
6 years ago

In 30796:

In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised.

See #30641

#9 @johnbillion
6 years ago

r30795 missed the ticket. Sad times.

#10 @johnbillion
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.