WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#30863 closed enhancement (wontfix)

Twenty Twelve: Support wp_style_add_data & wp_script_add_data

Reported by: valendesigns Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Bundled Theme Keywords: has-patch
Focuses: template Cc:

Description

This ticket is directly related to #16024 where support for adding conditional comments around enqueued JS is being worked on. When that has been committed, this should follow.

Attachments (2)

30863.diff (1.8 KB) - added by valendesigns 4 years ago.
30863.1.diff (1.9 KB) - added by valendesigns 4 years ago.

Download all attachments as: .zip

Change History (6)

@valendesigns
4 years ago

@valendesigns
4 years ago

#1 @valendesigns
4 years ago

  • Keywords has-patch added

Forgot to remove the $wp_styles global now that it's no longer being used.

#2 @ocean90
4 years ago

  • Keywords close added

That means we have to add back compat functionality or prevent activation on installs prior to 4.x. I vote for a wontfix.

#3 @lancewillett
4 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 4.2

#4 @obenland
4 years ago

  • Keywords close 2nd-opinion removed
  • Milestone 4.2 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I'm with ocean90. Apart from this being a backwards compatibility breaking change, historically we've been very conservative in porting back enhancements with default themes, for good reason. This is also why Twenty Twelve doesn't use wp_style_add_data() or registers HTML5 support, for example.

Let's keep it in mind for Twenty Sixteen.

Note: See TracTickets for help on using tickets.