WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#31129 closed defect (bug) (fixed)

Twenty Fifteen: Show RSS icon instead of WordPress icon in Social Links Menu

Reported by: artychan Owned by: lancewillett
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Would really appreciate it if adding a feed link (i.e. username.wordpress.com/feed ) to the Social Links Menu shows the RSS icon instead of the WordPress icon.

I would expect something similar to what's on the Social Links documentation:
http://en.support.files.wordpress.com/2014/09/illustratr-social-links-front-end.jpg

Right now, I'm having to use the separate RSS Links widget. While not difficult to do, it means making my menu significantly longer (because of all the extra padding and such) to add this one link.

Attachments (2)

31129.wordpress-com.png (105.2 KB) - added by SergeyBiryukov 7 years ago.
31129.diff (637 bytes) - added by iamtakashi 7 years ago.
Move RSS icon style rule at the bottom to prevent it from being overridden by other social icon rules.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
7 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Twenty Fiften : Show RSS icon instead of WordPress icon in Social Links Menu to Twenty Fifteen: Show RSS icon instead of WordPress icon in Social Links Menu

#2 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.2

The RSS icon is already there, but it currently expects a trailing slash.

I guess we could add another rule for /feed.

#3 @SergeyBiryukov
7 years ago

  • Keywords needs-patch good-first-bug added

#4 @artychan
7 years ago

  • Type changed from enhancement to defect (bug)

Yes, please. A user would never realize that a trailing slash is necessary.

Even with trailing slash, it's not working for me though. Using the hosted WordPress site.

In the menu, this is what I have:
Custom Link
URL: http://cynng.wordpress.com/feed/
Navigation Label: RSS

However, I saved it, and then on my blog, it's still showing the WordPress icon. WordPress automatically changes it to the secure version (on the public side, dashboard setting still shows regular http), https://cynng.wordpress.com/feed/ Not sure if that's affecting it?

You can see it in action on my blog, first social links icon: http://cynng.wordpress.com

#5 follow-up: @SergeyBiryukov
7 years ago

It looks like Twenty Fifteen on WordPress.com has some additional rules for wordpress.org and wordpress.com, which override the RSS icon rule.

If I disable those additional rules, I can see the RSS icon (see the screenshot).

#6 in reply to: ↑ 5 ; follow-up: @SergeyBiryukov
7 years ago

Replying to SergeyBiryukov:

It looks like Twenty Fifteen on WordPress.com has some additional rules for wordpress.org and wordpress.com, which override the RSS icon rule.

Correction: The standalone version of Twenty Fifteen has these rules too.

We should probably move the RSS icon rule to the bottom, to prevent it from being overridden by those rules.

#7 in reply to: ↑ 6 @iamtakashi
7 years ago

Replying to artychan:

Yes, please. A user would never realize that a trailing slash is necessary.

From readme.txt

RSS Feed (URLs with /feed/)

But thanks for reporthing this.

Replying to SergeyBiryukov:

We should probably move the RSS icon rule to the bottom, to prevent it from being overridden by those rules.

Good point. Let's do that.

@iamtakashi
7 years ago

Move RSS icon style rule at the bottom to prevent it from being overridden by other social icon rules.

#8 @iamtakashi
7 years ago

  • Keywords has-patch added; needs-patch good-first-bug removed

#9 @lancewillett
7 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 31283:

Twenty Fifteen: move RSS icon style rule lower to prevent it from being overridden by other social icon rules.

Props iamtakashi, fixes #31129.

#10 @artychan
7 years ago

Big thanks everyone, especially @iamtakashi for patch.

Note: See TracTickets for help on using tickets.