WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 2 years ago

#31178 closed defect (bug) (duplicate)

make sure that the menu index don't get overridden

Reported by: pbearne Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch
Focuses: administration Cc:

Description

This might not fly but here goes

There is a problem when adding items to the admin menu in that is possible to pick the same index as someone else.

There is protection for the default admin location but this relies on a static array of index.

So I have created patch that solves this by turning the tagart index (60) into 60.12345 $tagart_index. '.' .rand(1 ,1000) and recheck its not used.

I have not changed all the locations needed in the menu and we could apply this to the submenus as well.

For now I am added a function to the menu.php but this might better somewhere else (and renamed)

I wanted to see if it would fly first for doing more work etc.

Paul

Attachments (1)

menu.php.patch (2.1 KB) - added by pbearne 5 years ago.
concept patch

Download all attachments as: .zip

Change History (6)

@pbearne
5 years ago

concept patch

#2 in reply to: ↑ 1 @pbearne
5 years ago

Replying to SergeyBiryukov:

Related: #15595, #16856, #16946, #18622, #21315.

Thanks for the links Sergey

#3 @pbearne
5 years ago

  • Component changed from Administration to Plugins

#4 @DrewAPicture
4 years ago

  • Keywords has-patch added
  • Version trunk deleted

#5 @DrewAPicture
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Let's centralize discussion for this and other collision issues to #12718.

Note: See TracTickets for help on using tickets.