make sure that the menu index don't get overridden

[pbearne]

This might not fly but here goes

There is a problem when adding items to the admin menu in that is possible to pick the same index as someone else.

There is protection for the default admin location but this relies on a static array of index.

So I have created patch that solves this by turning the tagart index (60) into 60.12345 $tagart_index. '.' .rand(1 ,1000) and recheck its not used.

I have not changed all the locations needed in the menu and we could apply this to the submenus as well.

For now I am added a function to the menu.php but this might better somewhere else (and renamed)

I wanted to see if it would fly first for doing more work etc.

Paul

[pbearne]

concept patch

[SergeyBiryukov]

Related: #15595, #16856, #16946, #18622, #21315.

[pbearne]

Replying to SergeyBiryukov:

Related: #15595, #16856, #16946, #18622, #21315.

Thanks for the links Sergey

[DrewAPicture]

Let's centralize discussion for this and other collision issues to #12718.