WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#31226 closed defect (bug) (fixed)

Pasting a password does not trigger the Password strength indicator

Reported by: wimfeijen Owned by: dipesh.kakadiya
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Users Keywords: good-first-bug has-patch commit
Focuses: javascript, administration Cc:

Description

When creating a new user, pasting a password does not trigger the password strength indicator. The form gives an error on submit.

Workaround: type a space after the password, and then delete the space.

Why this annoys me: after filling the form completely with valid data, it gives an error on submit.

Using WordPress 4.1 Dutch language

Attachments (3)

31226.diff (720 bytes) - added by dipesh.kakadiya 7 years ago.
patch for trigger the Password strength indicator while paste password using mouse
31226_new.diff (736 bytes) - added by dipesh.kakadiya 7 years ago.
revise patch for trigger the Password strength indicator while paste password using mouse
31225_latest.diff (732 bytes) - added by dipesh.kakadiya 7 years ago.
I found on is more suitable rather than bind so patch is revice

Download all attachments as: .zip

Change History (16)

#1 @knutsp
7 years ago

  • Keywords reporter-feedback added

I can not verify this. Pasting something into the passord field immediately triggers the password strength meter.

Did you try this with no plugins activated?

#2 @jorbin
7 years ago

  • Component changed from General to Administration
  • Focuses javascript added
  • Keywords needs-patch good-first-bug added; reporter-feedback removed

Confirmed in Chrome 39 on osx. Issue happens when you paste via mouse but not when you paste with cmd-v.

#3 @helen
7 years ago

Right - we only check on keyup. Should check for paste perhaps, although if I recall correctly that requires a setTimeout. However, I don't believe that core actually rejects weak passwords - sounds like that may be a plugin.

@dipesh.kakadiya
7 years ago

patch for trigger the Password strength indicator while paste password using mouse

#4 @dipesh.kakadiya
7 years ago

  • Keywords has-patch added; needs-patch removed

#5 @DrewAPicture
7 years ago

  • Milestone changed from Awaiting Review to 4.2
  • Owner set to dipesh.kakadiya
  • Status changed from new to assigned

#6 follow-up: @SergeyBiryukov
7 years ago

  • Keywords needs-refresh added

val('') was added in [10046] to avoid autocomplete issues, and probably should not be removed.

@dipesh.kakadiya
7 years ago

revise patch for trigger the Password strength indicator while paste password using mouse

#7 @dipesh.kakadiya
7 years ago

  • Keywords needs-refresh removed

#8 in reply to: ↑ 6 @dipesh.kakadiya
7 years ago

I submitted revise patch please review it.

Replying to SergeyBiryukov:

val('') was added in [10046] to avoid autocomplete issues, and probably should not be removed.

#9 @dipesh.kakadiya
7 years ago

@SergeyBiryukov

any update on this issue?

#10 follow-up: @helen
7 years ago

Why did you go with .bind() instead of .on()?

#11 in reply to: ↑ 10 @dipesh.kakadiya
7 years ago

Replying to helen:

Why did you go with .bind() instead of .on()?

As I know bind is also indicate to on method that only reason I used bind.

@dipesh.kakadiya
7 years ago

I found on is more suitable rather than bind so patch is revice

#12 @SergeyBiryukov
7 years ago

  • Component changed from Administration to Users
  • Focuses administration added
  • Keywords commit added

#13 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31483:

When creating a new user, pasting a password should update the password strength indicator.

props dipesh.kakadiya.
fixes #31226.

Note: See TracTickets for help on using tickets.