Opened 10 years ago
Last modified 4 months ago
#31254 new defect (bug)
Post errors show success borders
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | 3.7 |
Component: | Posts, Post Types | Keywords: | needs-screenshots has-patch |
Focuses: | ui, administration | Cc: |
Description
Similar to #31241 if a post delete/update action fails a green border shows instead of red. I'm not sure what action should be taken here since failures and successes seem to be able to be displayed in the same message box.
Attachments (2)
Change History (11)
#1
@
10 years ago
- Summary changed from Post errors show succes borders to Post errors show success borders
#2
@
10 years ago
- Component changed from Administration to Posts, Post Types
- Focuses administration added
#5
follow-up:
↓ 6
@
4 years ago
- Keywords needs-patch removed
I'm not able to reproduce this problem.
@ninnypants => Can you provide screenshots and/or steps of how to reproduce this problem?
Doing so will help us to reproduce and investigate.
Note: Removing needs-patch
until we can reproduce and confirm due to core.
#6
in reply to:
↑ 5
@
4 years ago
Replying to hellofromTonya:
I'm not able to reproduce this problem.
I can reproduce by visiting /wp-admin/edit.php?locked=1
, which would be the same as opening a post as one user and then trying to update it from the list table as another user.
This displays a "1 post not updated, somebody is editing it" message with a green border, same as a success message.
I think the fix would be to display the locked
error separately from other messages, with the error
class instead of updated
.
@
4 years ago
Locked error shown as admin "notice" in green border when attempting to update from bulk edits when another user has post edit open
#7
@
4 years ago
- Keywords needs-patch added; reporter-feedback removed
Thanks @SergeyBiryukov for identifying the issue with a locked state. And yes, I was now able to reproduce.
Steps to reproduce:
- Log into one browser as one user, e.g. user
admin
. - Go to "Posts".
- Click the checkbox next a post.
- Click "Bulk actions" and then "Edit".
- Switch to another browser and log in as different user, e.g. user
tester1
. - Go to "Posts".
- Click on the above post title to open the editor.
- Switch back to the
admin
browser. - Edit something like selecting a category and/or changing the post's author.
- Click the "Update" button.
An error message appears, but is shown in a green border:
1 post not updated, somebody is editing it.
Here is the HTML for the message:
<div id="message" class="updated notice is-dismissible"> <p>1 post not updated, somebody is editing it.</p> <button type="button" class="notice-dismiss"><span class="screen-reader-text">Dismiss this notice.</span></button> </div>
This ticket was mentioned in PR #6897 on WordPress/wordpress-develop by @nirajgirixd.
8 months ago
#8
- Keywords has-patch added; needs-patch removed
## Description
This PR corrects the styling of admin notices by ensuring error messages display with the appropriate border color.
## Why?
- Error messages were incorrectly shown with a success (green) border
## Screencast
https://github.com/WordPress/wordpress-develop/assets/51747980/897e3fad-7826-4fe9-9a23-5333df3b40e4
---
## Trac ticket: https://core.trac.wordpress.org/ticket/31254
@ninnypants Can you provide an example for a core post/page-related failure message that would get displayed with a success border?