WordPress.org

Make WordPress Core

Opened 7 years ago

Last modified 9 months ago

#31254 new defect (bug)

Post errors show success borders

Reported by: ninnypants Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.7
Component: Posts, Post Types Keywords: needs-screenshots needs-patch
Focuses: ui, administration Cc:

Description

Similar to #31241 if a post delete/update action fails a green border shows instead of red. I'm not sure what action should be taken here since failures and successes seem to be able to be displayed in the same message box.

Attachments (2)

locked-error-message-green.png (93.9 KB) - added by hellofromTonya 9 months ago.
Reproduced "green" error message: 1 post not updated, somebody is editing it.
reproducing-31254-locked.gif (4.3 MB) - added by hellofromTonya 9 months ago.
Locked error shown as admin "notice" in green border when attempting to update from bulk edits when another user has post edit open

Change History (9)

#1 @SergeyBiryukov
7 years ago

  • Summary changed from Post errors show succes borders to Post errors show success borders

#2 @SergeyBiryukov
7 years ago

  • Component changed from Administration to Posts, Post Types
  • Focuses administration added

#3 @swissspidy
6 years ago

  • Keywords needs-patch added

#4 @DrewAPicture
4 years ago

  • Keywords reporter-feedback needs-screenshots added

@ninnypants Can you provide an example for a core post/page-related failure message that would get displayed with a success border?

#5 follow-up: @hellofromTonya
9 months ago

  • Keywords needs-patch removed

I'm not able to reproduce this problem.

@ninnypants => Can you provide screenshots and/or steps of how to reproduce this problem?

Doing so will help us to reproduce and investigate.

Note: Removing needs-patch until we can reproduce and confirm due to core.

#6 in reply to: ↑ 5 @SergeyBiryukov
9 months ago

Replying to hellofromTonya:

I'm not able to reproduce this problem.

I can reproduce by visiting /wp-admin/edit.php?locked=1, which would be the same as opening a post as one user and then trying to update it from the list table as another user.

This displays a "1 post not updated, somebody is editing it" message with a green border, same as a success message.

I think the fix would be to display the locked error separately from other messages, with the error class instead of updated.

@hellofromTonya
9 months ago

Reproduced "green" error message: 1 post not updated, somebody is editing it.

@hellofromTonya
9 months ago

Locked error shown as admin "notice" in green border when attempting to update from bulk edits when another user has post edit open

#7 @hellofromTonya
9 months ago

  • Keywords needs-patch added; reporter-feedback removed

Thanks @SergeyBiryukov for identifying the issue with a locked state. And yes, I was now able to reproduce.

Steps to reproduce:

  1. Log into one browser as one user, e.g. user admin.
  2. Go to "Posts".
  3. Click the checkbox next a post.
  4. Click "Bulk actions" and then "Edit".
  5. Switch to another browser and log in as different user, e.g. user tester1.
  6. Go to "Posts".
  7. Click on the above post title to open the editor.
  8. Switch back to the admin browser.
  9. Edit something like selecting a category and/or changing the post's author.
  10. Click the "Update" button.

An error message appears, but is shown in a green border:

1 post not updated, somebody is editing it.

Here is the HTML for the message:

<div id="message" class="updated notice is-dismissible">
     <p>1 post not updated, somebody is editing it.</p>
     <button type="button" class="notice-dismiss"><span class="screen-reader-text">Dismiss this notice.</span></button>
</div>
Note: See TracTickets for help on using tickets.