Bundled themes and .screen-reader-text

[afercia]

All bundled themes have now their CSS .screen-reader-text rules defined but they're different from the one recommended in the Codex and they also won't cover edge cases.

The rule used in core, which is very similar to the one now recommended in the Codex, tries to cover also edge cases, and for some good reasons, see for example r26602.

Please consider to update all bundled themes with the officially recommended rule, see:
Codex
​https://codex.wordpress.org/CSS#WordPress_Generated_Classes
Make WordPress Accessible related post
​https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/
Theme Review Team related post
​https://make.wordpress.org/themes/2015/01/26/supporting-screen-reader-text/

[lancewillett]

Thank you for the ticket. Could you please be more specific about which themes need which CSS rules?

[afercia]

Thank you for the feedback:
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyten/style.css#L338
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyeleven/style.css#L497
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwelve/style.css#L504
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentythirteen/style.css#L539
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyfourteen/style.css#L718
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyfifteen/style.css#L1154

they all use a different rule, my proposal would be to standardize and just use the rule recommended in the Codex.

[lancewillett]

Twenty Fifteen is following the current rules. The others will need patches to standardize around:

	clip: rect(1px, 1px, 1px, 1px);
	overflow: hidden;
	position: absolute !important;
	height: 1px;
	width: 1px;

[lancewillett]

Style updates for Fourteen to Ten

[lancewillett]

Patch addresses Twenty Ten to Fourteen.

[afercia]

Replying to lancewillett:

Twenty Fifteen is following the current rules.

Thanks very much Lance, you're right. Was confused because core uses also

margin: -1px;
padding: 0;
border: 0;

and a different clip respect to the rule recommended in the Codex. Thanks.

[lancewillett]

In 31464:

Bundled themes: update CSS rules for .screen-reader-text to be consistent with current accessibility guidelines. Fixes #31279.