Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#31279 closed enhancement (fixed)

Bundled themes and .screen-reader-text

Reported by: afercia's profile afercia Owned by: lancewillett's profile lancewillett
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: needs-testing has-patch
Focuses: accessibility Cc:

Description

All bundled themes have now their CSS .screen-reader-text rules defined but they're different from the one recommended in the Codex and they also won't cover edge cases.

The rule used in core, which is very similar to the one now recommended in the Codex, tries to cover also edge cases, and for some good reasons, see for example r26602.

Please consider to update all bundled themes with the officially recommended rule, see:
Codex
https://codex.wordpress.org/CSS#WordPress_Generated_Classes
Make WordPress Accessible related post
https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/
Theme Review Team related post
https://make.wordpress.org/themes/2015/01/26/supporting-screen-reader-text/

Attachments (1)

31279.diff (3.7 KB) - added by lancewillett 9 years ago.
Style updates for Fourteen to Ten

Download all attachments as: .zip

Change History (9)

#1 @lancewillett
9 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.2

Thank you for the ticket. Could you please be more specific about which themes need which CSS rules?

#3 follow-up: @lancewillett
9 years ago

Twenty Fifteen is following the current rules. The others will need patches to standardize around:

	clip: rect(1px, 1px, 1px, 1px);
	overflow: hidden;
	position: absolute !important;
	height: 1px;
	width: 1px;

@lancewillett
9 years ago

Style updates for Fourteen to Ten

#4 @lancewillett
9 years ago

  • Keywords needs-testing has-patch added; needs-patch removed

#5 @lancewillett
9 years ago

Patch addresses Twenty Ten to Fourteen.

#6 in reply to: ↑ 3 @afercia
9 years ago

Replying to lancewillett:

Twenty Fifteen is following the current rules.

Thanks very much Lance, you're right. Was confused because core uses also

margin: -1px;
padding: 0;
border: 0;

and a different clip respect to the rule recommended in the Codex. Thanks.

#7 @lancewillett
9 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 31464:

Bundled themes: update CSS rules for .screen-reader-text to be consistent with current accessibility guidelines. Fixes #31279.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 years ago

Note: See TracTickets for help on using tickets.