WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31302 closed defect (bug) (fixed)

Tests_Dependencies_jQuery::test_wp_script_is_dep_enqueued Failed

Reported by: valendesigns Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Build/Test Tools Keywords:
Focuses: Cc:
PR Number:

Description

I'm not sure if this is specific to me, or what is going on here. However, I ran phpunit and got back this response.

1) Tests_Dependencies_jQuery::test_wp_script_is_dep_enqueued
Failed asserting that true is false.

/Volumes/Dropbox/Dropbox/httpdocs/wordpress-git.dev/tests/phpunit/tests/dependencies/jquery.php:80

I checked line 80 and there's no good reason why underscore would be enqueued by jquery-ui-accordion. Is anyone else experiencing a failure with the test_wp_script_is_dep_enqueued test?

Change History (6)

#1 @boonebgorges
5 years ago

See attachment 30936.7.diff on #30936. Ping @ocean90

#3 @valendesigns
5 years ago

Thank you both for the quick reply. Should this ticket remain open or should it be fixed in #30936?

#4 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 31426:

Fix failing Tests_Dependencies_jQuery::test_wp_script_is_dep_enqueued test.

[31370] has broken the test because the Customizer test enqueues some scripts. Unset $GLOBALS['wp_scripts'] on tearDown() so other tests will start with zero enqueued scripts.

see #30936.
fixes #31302.

#5 @ocean90
5 years ago

  • Milestone changed from Awaiting Review to 4.2

#6 @valendesigns
5 years ago

Perfect! Thank you @ocean90 for the quick fix.

Note: See TracTickets for help on using tickets.