options-general.php have "Site Language" set to (current view language) but should be (site language)

[Profforg]

Hi.

While you edit General Options /wp-admin/options-general.php option "Site Language" always set to (current view language) but should be (site language). Let's say that you have installed any WordPress plugin to have admin panel and website to be in your language (Example: WP Native Dashboard, WPML Multilingual CMS), you are comfortably use admin interface in your language, but when you come to general options and edit something - you ALWAYS need to set language to correct site language. It's a pain to have this.

I think "Site Language" should be Site Language, not current language in which you view admin panel.

I think it's a bug. If not, then consider this as enchancement request.

Versions affected: After removing WPLANG constant from wp-config.php. If i remember right, it's 4.0+.

Sincerely,

Alex.

[SergeyBiryukov]

Related: comment:5:ticket:29362

[khromov]

This is a bug for sure. There is a patch over in #29362, hoping it gets traction.

[jubstuff]

This is a patch originally from @khromov in ticket #29362.

It correctly set the option as the site language in the language dropdown in general settings if, for example, the dashboard and site language differ.

I used the "WP Native Dashboard" plugin to test it out.

G

[swissspidy]

I'd say this is a one liner, just replacing $locale = get_locale(); with $locale = get_option( 'WPLANG' );.

[brokenflipside]

This is a refresh

[brokenflipside]

I have made the recommended changes and attached the patch. I changed the language refreshed and it was displaying the correct choice as active.

[brokenflipside]

Uploaded the wrong file, this is correct

[swissspidy]

I've tested this using Polylang on both trunk and 4.3.

Current behaviour:

• Set site language to German
• Change user language to English
• Admin is in English and the site language is displayed as being English

With the patch applied:

• Set site language to German
• Change user language to English
• Admin is in English and the site language is displayed correctly as being German

According to @ocean90 get_locale was probably used for compatibility reasons for sites that don't have the WPLANG option set, but the upgrade_400() function sets it for any site anyway.

Therefore the patch should be good to go.

[swissspidy]

Apparently there was a good reason for using get_locale(), see https://core.trac.wordpress.org/ticket/29362#comment:8.

@ocean90 You decide ;)

[ocean90]

get_locale() is the site language. It gets used for update checks for example. It also includes the back compat stuff like support for the old WPLANG constant or the $wp_local_package global.

#29783 will introduce a new API to separate user and site language and should solve this issue too.

[swissspidy]

Closing in favour of #29783.

@jubstuff @brokenflipside You're very welcome to work on patches for that ticket :-)