WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 weeks ago

#31390 closed defect (bug) (wontfix)

Investigate static analysis errors

Reported by: Caipre Owned by: desrosj
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: coding-standards Cc:
PR Number:

Description (last modified by desrosj)

I'm the author of hussar, a tool that leverages the static analysis functionality of HHVM. I ran the tool against WordPress master and it found ~200 errors. Some of these look like false-positives, but I figured I'd let you guys decide.

https://gist.githubusercontent.com/caipre/feb7f9fe46dc2fa90a79/raw/0b0556b65b490b3c7e12f5399dda049d9e71679b/gistfile1.txt

More details about hussar here: https://github.com/wayfair/hussar

Change History (4)

#2 @DrewAPicture
5 years ago

  • Owner set to wonderboymusic
  • Status changed from new to assigned
  • Version trunk deleted

#3 @desrosj
4 weeks ago

  • Description modified (diff)
  • Focuses coding-standards added
  • Owner changed from wonderboymusic to desrosj

I'm going to close this out for a few reasons.

  • Support for HHVM was officially removed from WordPress in 2017. While this doesn't mean someone cannot use HHVM to re-run this analysis, I'm willing to bet that the number of people who are able and willing to get an HHVM environment running is very low (if any). This also makes it difficult for someone to check that the issues were fixed.
  • hussar has not received a meaningful update in almost 5 years and seems largely abandoned.
  • The PHP_CodeSniffer, [WordPress Coding Standards for PHP_CodeSniffer ruleset], and [PHPCompatibility/PHPCompatibilityWP PHPCompatibility] rulesets (which are much more modern and better maintained) have emerged as the best static analysis tools.

While the results of this analysis were valid at the time, it's highly likely a lot of these issues have been fixed or flagged elsewhere. I'm going to close as a wontfix, but if someone wants to pick this back up and run with it, feel free!

#4 @johnbillion
4 weeks ago

  • Resolution set to wontfix
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.