Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#31610 closed defect (bug) (fixed)

Scroll bleed in the session expired log in modal on iOS

Reported by: ryan Owned by: ocean90
Priority: normal Milestone: 4.2
Component: Login and Registration Version: 4.2
Severity: normal Keywords: make-flow has-patch commit
Cc: Focuses: ui, javascript

Description

Attachments (6)

31610.diff​ (585 bytes ) - added by adamsilverstein 12 years ago.
IMG_0871.PNG​ (140.5 KB ) - added by ryan 12 years ago.
Page beneath still scrolls
IMG_0872.PNG​ (171.1 KB ) - added by ryan 12 years ago.
Stacked log in modals, both with bad scrolling
IMG_0875.PNG​ (241.6 KB ) - added by ryan 12 years ago.
31610.patch​ (1.6 KB ) - added by ocean90 12 years ago.
31610..2.patch​ (2.0 KB ) - added by ocean90 12 years ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in ​Slack in #core-flow by boren. ​View the logs.


12 years ago

#2 @DrewAPicture
12 years ago

  • Priority normal → high

#3 @adamsilverstein
12 years ago

  • Focuses javascript added
  • Keywords has-patch dev-feedback added

In 31610.diff​:

  • When session expired modal opens, add the 'modal-open' class to the body, triggering overflow:hidden style on body, preventing background scrolling via swipe
  • When modal is closed, remove 'modal-open' class

Tested on Chrome debugger and background no longer scrolls.

@ryan
12 years ago

Page beneath still scrolls

@ryan
12 years ago

Stacked log in modals, both with bad scrolling

@ryan
12 years ago

#4 @ryan
12 years ago

Another scrolling issue that requires real hardware to reproduce, it seems.

Last edited 12 years ago by ryan (previous) (diff)

@ocean90
12 years ago

@ocean90
12 years ago

#5 @ocean90
12 years ago

  • Keywords dev-feedback removed

31610..2.patch​ should do it. Includes also a fix for screens with width <= 380px. (And a change to JS so that the modals opens directly, for testing)

Sometimes the page beneath still can be scrolled and produces the bounce effect. But this happens for all modals. AFAIK this can only be fixed if the modal fills the whole viewport.

#6 @helen
12 years ago

  • Keywords commit added

Looks good, go for it. Without the debug part, of course. :)

#7 @ocean90
12 years ago

  • Owner set to ocean90
  • Resolution → fixed
  • Status new → closed

In 31945:

Disable body scrolling when session expired log in modal is open.

Fixes also the missing close icon if screen width is less than 380px.

props adamsilverstein, ocean90.
fixes #31610.

#8 @DrewAPicture
12 years ago

  • Priority high → normal

#9 @helen
12 years ago

In 32073:

Modals: Significantly improve the touch scrolling experience.

This particularly fixes the attachment and plugin details modals, but also improves other modals such as wpLink and interim login.

props iseulde.
fixes #31609, #31611. see #31610, #31612.

Note: See TracTickets for help on using tickets.