count_user_posts Should Accept Multiple Post Types

[nikonratm]

It's great that the count_user_posts function now accepts a post_type parameter as of 4.1 but I think it would be much more useful if it accepted multiple post types, I think I will go ahead and implement this =)

[nikonratm]

Updated count_user_posts to accept multiple post types

[nikonratm]

Updated get_posts_by_author_sql to accept multiple post types

[nikonratm]

fixed get_posts_by_author_sql respects capabilities for all included post types

[nikonratm]

patch file that includes changes to both post.php and user.php

[boonebgorges]

Thanks for the patch, nikonratm!

Your $cap_final logic doesn't look like it will work properly. Say I'm querying for three post types: array( 'foo', 'bar', 'baz' ). And let's say that I have the read_private_posts cap for 'baz' but not for 'foo' and 'bar'. In this situation, it looks like the last post type cap will overwrite the previous two, and private posts for all three post types will be returned. If we're going to add the improvement suggested in this ticket, the SQL will need to look like this:

... WHERE (
  ( post_type = 'foo' AND post_status = 'publish' )
  OR
  ( post_type = 'bar' AND post_status = 'publish' )
  OR
  ( post_type = 'baz' AND ( post_status = 'publish' OR post_status = 'private' ) ) 
)

(You'll have to make sure the "users can view their own private posts" stuff works too.)

It'll help enormously to write some unit tests describing scenarios like the above. See https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/post/getPostsByAuthorSql.php for some examples. (You could also write indirect tests for count_user_posts().)

Small additional point: Make sure you don't break backward compatibility for singular $post_type. If a string has been passed, cast it to array( $post_type ).

[nikonratm]

updated to respect capabilities per post type

[nikonratm]

Ah, good point. I've updated the function to do as you suggested, as well as allow for string (i.e. single)
$post_types arguments.

I don't have the time to write tests right now but I would be happy to do that.

[nikonratm]

Added unit testing

[nikonratm]

Cool, added a unit test for multiple post types and for testing when a user has access to private posts for only certain post types ( test_user_has_access_only_to_private_posts_for_certain_post_types )

[nikonratm]

updated to allow public_only as part of main function

[nikonratm]

removed silly echo line used for testing

[boonebgorges]

This looks pretty good.

[boonebgorges]

In 32523:

Support multiple post types in count_user_posts() and other functions that use get_posts_by_author_sql().

Props nikonratm.
Fixes #32243.

[DrewAPicture]

Since we added an additional type for $post_type, we need to note that in the changelogs as well.

[boonebgorges]

DrewAPicture - Can you be more specific? I added a changelog item to get_posts_by_author_sql(). I didn't add the same thing to all functions that call get_posts_by_author_sql(), though I did update the param definitions. Please give guidance on how you want to handle this.

[DrewAPicture]

Replying to boonebgorges:

DrewAPicture - Can you be more specific? I added a changelog item to get_posts_by_author_sql(). I didn't add the same thing to all functions that call get_posts_by_author_sql(), though I did update the param definitions. Please give guidance on how you want to handle this.

$post_type only accepted a string before, and now accepts either a string or an array in three places. We need to document that it now accepts an array in the changelog.

[boonebgorges]

In 32524:

Streamline support for multiple post types in get_posts_by_author_sql().

• Don't accept a comma-separated list, only a single post type or an array of post types. This is easier to document.
• Add changelog entries to all calling functions.

Props DrewAPicture.
Fixes #32243.