WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#32310 closed defect (bug) (fixed)

Timeout on big tables upgrade to utf8mb4_unicode_ci

Reported by: gabrielperezs Owned by: pento
Milestone: 4.2.3 Priority: normal
Severity: normal Version: 4.2
Component: Upgrade/Install Keywords:
Focuses: performance Cc:

Description

If a table like wp_options is too big, the upgrade process can't finish. In my case, the table need around 12 minutes to this change so the wordpres upgrade process always hive a timeout.

The core don't check if the table has the correct collation and send the order to change it again, is a loop never ends.

Attachments (1)

patch.diff (1.0 KB) - added by gabrielperezs 3 years ago.
Patch to check the actual collation of a table before try to change it again

Download all attachments as: .zip

Change History (5)

@gabrielperezs
3 years ago

Patch to check the actual collation of a table before try to change it again

This ticket was mentioned in Slack in #core by lonchbox. View the logs.


3 years ago

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.2.3

#3 @pento
3 years ago

In 32456:

Upgrades: If a table has already been converted to utf8mb4, there's no need to try and convert it again.

Props gabrielperezs for the initial patch.

See #32310.

#4 @pento
3 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 32457:

Upgrades: If a table has already been converted to utf8mb4, there's no need to try and convert it again.

Props gabrielperezs for the initial patch.

Merge of [32456] to the 4.2 branch.

Fixes #32310.

Note: See TracTickets for help on using tickets.