WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#32350 closed defect (bug) (fixed)

Sanitize_Option needs to be able to handle a WP Error Object

Reported by: chriscct7 Owned by: wonderboymusic
Priority: normal Milestone: 4.2.3
Component: Formatting Version: 4.2
Severity: normal Keywords: has-patch fixed-major
Cc: Focuses:

Description (last modified by chriscct7)

As discovered in #32212, sanitize_option cannot currently handle a WP Error Object being returned. This patch solves that problem. Related #32351

Attachments (2)

32308.1.patch​ (7.8 KB ) - added by chriscct7 11 years ago.
32350.diff​ (7.2 KB ) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (10)

@chriscct7
11 years ago

#1 @chriscct7
11 years ago

  • Owner set to chriscct7
  • Status new → assigned

#2 @chriscct7
11 years ago

  • Status assigned → accepted

#3 @chriscct7
11 years ago

  • Description modified (diff)

@wonderboymusic
11 years ago

#4 @wonderboymusic
11 years ago

  • Owner changed from chriscct7 to wonderboymusic
  • Status accepted → assigned

#5 @wonderboymusic
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 32791:

sanitize_option() needs to handle WP_Error. DRY the conditional calls to add_settings_error().

Props chriscct7 for an initial patch.
Fixes #32350.

#6 @wonderboymusic
11 years ago

  • Resolution fixed
  • Status closed → reopened

Reopening for 4.2.3 consideration

#7 @samuelsidler
11 years ago

  • Keywords fixed-major added

#8 @pento
11 years ago

  • Resolution → fixed
  • Status reopened → closed

In 33326:

sanitize_option() needs to handle WP_Error. DRY the conditional calls to add_settings_error().

Merge of [32791] to the 4.2 branch.

Props wonderboymusic, chriscct7 for an initial patch.

Fixes #32350.

Note: See TracTickets for help on using tickets.