Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#32369 closed defect (bug) (fixed)

Document the arguments for wp_new_comment

Reported by: rachelbaker's profile rachelbaker Owned by: rachelbaker's profile rachelbaker
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Comments Keywords: has-patch
Focuses: docs Cc:

Description

Clarifies the $commentdata param description added in r32500.
wp_new_comment() does not allow the same $commentdata array values and has different defaults than wp_insert_comment().

Lets give wp_new_comment a $commentdata array hash notation all its own.

Attachments (3)

32369.patch (1.5 KB) - added by rachelbaker 10 years ago.
32369.2.patch (2.1 KB) - added by DrewAPicture 9 years ago.
refresh + two new arguments
32369.3.patch (2.1 KB) - added by rachelbaker 9 years ago.
Added legacy user_ID parameter information

Download all attachments as: .zip

Change History (9)

@rachelbaker
10 years ago

#1 @DrewAPicture
10 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

#2 @rachelbaker
10 years ago

  • Keywords needs-refresh added

I am missing some arguments here. I will refresh the patch.

#3 @rachelbaker
10 years ago

  • Milestone changed from 4.3 to Future Release
  • Owner changed from DrewAPicture to rachelbaker
  • Status changed from reviewing to accepted

Moving off the 4.3 milestone until I refresh the patch.

@DrewAPicture
9 years ago

refresh + two new arguments

#4 follow-up: @DrewAPicture
9 years ago

  • Keywords needs-refresh removed
  • Milestone changed from Future Release to 4.4

@rachelbaker: Added 32369.2.patch which refreshes your patch and adds entries for the comment user agent and comment author IP, added in 4.3.

If you could please review those entries for their validity and either iterate the patch and/or make a commit recommendation, that would be splendid.

@rachelbaker
9 years ago

Added legacy user_ID parameter information

#5 in reply to: ↑ 4 @rachelbaker
9 years ago

Replying to DrewAPicture:

If you could please review those entries for their validity and either iterate the patch and/or make a commit recommendation, that would be splendid.

@DrewAPicture,

I added an additional line to document the legacy user_ID key that was normalized in #23231. The rest looked good. Thanks for the assist :)

Last edited 9 years ago by rachelbaker (previous) (diff)

#6 @DrewAPicture
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33730:

Docs: Document the default comment data arguments for wp_new_comment().

Props rachelbaker, DrewAPicture
Fixes #32369.

Note: See TracTickets for help on using tickets.