allowed_themes filter not consistent on multisite network

[fliespl]

Using allowed_themes filter allows only to set themes which are displayed for choosing.

Unfortunately if we add single exclusive theme for just one blog - user can't use it.

This is due to check in "is_allowed" method of WP_Theme class. It doesn't involve allowed_themes filter and fails with "Cheating, huh?" warning.

Steps to reproduce:

1. Use filter to add exclusive blog:

   add_filter('allowed_themes', function($tpls) {
      if(logic) {
         $tpls['exclusive_theme'] = true;
      }
      return $tpls;
   }
   

2. Try to enable it through themes menu.

Expected result: theme is changed
What happens instead: "Cheating, huh?" warning is displayd.

Possible fix included.

[jeremyfelt]

Hi @fliespl, thanks for the ticket.

I believe this is a duplicate of #28436, as the changes there should correct this. Can you take a look and confirm?

[fliespl]

Duplicate of #28436.

Hi @jeremyfelt,
yeah seems that way. Sorry for duplicate - haven't seen that one.