WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#32448 closed defect (bug) (fixed)

Widget Region without a description has an empty space

Reported by: paulwilde's profile paulwilde Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.8
Component: Widgets Keywords: has-patch commit
Focuses: Cc:

Description

This patch removes the blank empty div should no widget description be provided.

Attachments (2)

32448.diff​ (615 bytes) - added by paulwilde 9 years ago.
widget-descriptions.png​ (32.5 KB) - added by paulwilde 9 years ago.

Download all attachments as: .zip

Change History (7)

@paulwilde
9 years ago

@paulwilde
9 years ago

#1 @MikeHansenMe
9 years ago

  • Keywords has-patch added

#2 @welcher
9 years ago

  • Keywords dev-feedback added

Related #23012.

#3 @welcher
9 years ago

  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 4.4

#4 @swissspidy
9 years ago

  • Keywords commit added; dev-feedback 2nd-opinion removed
  • Version changed from 4.2.2 to 3.8

There's a min-height configured for the .sidebar-description, which was added in [26140] as part of the MP6 merge.

Not really related to #23012 as this isn't about default widgets.

The patch looks good to me, works as expected.

#5 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33934:

Widgets: Don't display sidebar description container if it's empty.

Props paulwilde.
Fixes #32448.

Note: See TracTickets for help on using tickets.