WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#32494 closed defect (bug) (fixed)

Semantic elements for non-link links: Help and Screen Options

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: has-patch commit semantic-buttons
Focuses: accessibility Cc:

Description

For semantics and accessibility, links used as UI controls that are not real links but act as buttons should be buttons, see #26504.
The "Help" and "Screen Options" links already use an aria-expanded attribute and they just need to be marked up as buttons, with small CSS and JavaScript adjustments.

Attachments (2)

32494.patch​ (4.4 KB) - added by afercia 9 years ago.
32494.2.patch​ (4.4 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (9)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • Improve the "Help" and "Screen Options" controls accessibility making them real buttons.

This ticket was mentioned in ​Slack in #accessibility by afercia. ​View the logs.
9 years ago

#3 @afercia
9 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to afercia
  • Status changed from new to assigned

#4 @afercia
9 years ago

  • Keywords commit added

@afercia
9 years ago

#5 @afercia
9 years ago

Updated patch with coding standards.

#6 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32844:

Semanticize Help and Screen Options toggle.

Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.

#7 @afercia
7 years ago

  • Keywords semantic-buttons added
Note: See TracTickets for help on using tickets.