#32535 closed defect (bug) (fixed)
Remove title attributes: class-wp-users-list-table.php
Reported by: | afercia | Owned by: | obenland |
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Users | Keywords: | has-patch, commit, title-attribute |
Focuses: | ui, accessibility | Cc: |
Description
Related #24766
Repeating the email address in the title attribute just to prepend "E-mail: " doesn't add any valuable information, it's redundant and I'd recommend to remove that. The posts count title attribute text can be moved to a screen-reader-text
, additionally the clickable area is really small, I'd recommend to make it a bit bigger.
Side note: maybe the "Posts" table header text should be "Number of Posts"?
Attachments (3)
Change History (14)
#2
follow-up:
↓ 3
@
9 years ago
I haven't tested this patch yet, but I think that the CSS adding padding, while helpful in this context, may be too broad - it looks like it will apply to a lot of other links where the additional padding could cause display problems. Did you check whether this causes display problems in other table links?
#3
in reply to:
↑ 2
@
9 years ago
- Milestone changed from Awaiting Review to 4.3
- Owner set to afercia
- Status changed from new to assigned
Replying to joedolson:
I haven't tested this patch yet, but I think that the CSS adding padding, while helpful in this context, may be too broad - it looks like it will apply to a lot of other links where the additional padding could cause display problems. Did you check whether this causes display problems in other table links?
Good point Joe, as far as I see column-posts
is used only in this table. Will double check and maybe add a specific selector on the count links, just in case.
#4
follow-up:
↓ 5
@
9 years ago
- Focuses ui added
- Keywords commit added
Refreshed patch adds a specific CSS selector for the posts count link to avoid possible conflicts, just in case. A bigger clickable area is good on smaller screens and doesn't harm on desktop. Of course it will be a bit bigger when the posts count number will have 2, 3, 4. etc. digits but seems the table column has a fixed width and is always large enough. Feel free to reduce it a bit if you feel it's too big. See screenshot.
#5
in reply to:
↑ 4
@
9 years ago
Replying to afercia:
A bigger clickable area is good on smaller screens and doesn't harm on desktop.
It introduces a visual inconsistency with other lists, and also within the column between authors with posts and authors without. How about we limit the fix to just remove the title attribute for now?
In the proposed patch: