Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#32535 closed defect (bug) (fixed)

Remove title attributes: class-wp-users-list-table.php

Reported by: afercia's profile afercia Owned by: obenland's profile obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Users Keywords: has-patch, commit, title-attribute
Focuses: ui, accessibility Cc:

Description

Related #24766

Repeating the email address in the title attribute just to prepend "E-mail: " doesn't add any valuable information, it's redundant and I'd recommend to remove that. The posts count title attribute text can be moved to a screen-reader-text, additionally the clickable area is really small, I'd recommend to make it a bit bigger.

https://cldup.com/YK7OX9fVvt.png

Side note: maybe the "Posts" table header text should be "Number of Posts"?

Attachments (3)

32535.patch (1.8 KB) - added by afercia 9 years ago.
32535.2.patch (1.8 KB) - added by afercia 9 years ago.
32535.3.patch (1.3 KB) - added by afercia 9 years ago.

Download all attachments as: .zip

Change History (14)

@afercia
9 years ago

#1 @afercia
9 years ago

  • Keywords has-patch added

In the proposed patch:

  • remove title attributes from Users table list, make the posts count links clickable area a bit bigger

#2 follow-up: @joedolson
9 years ago

I haven't tested this patch yet, but I think that the CSS adding padding, while helpful in this context, may be too broad - it looks like it will apply to a lot of other links where the additional padding could cause display problems. Did you check whether this causes display problems in other table links?

#3 in reply to: ↑ 2 @afercia
9 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to afercia
  • Status changed from new to assigned

Replying to joedolson:

I haven't tested this patch yet, but I think that the CSS adding padding, while helpful in this context, may be too broad - it looks like it will apply to a lot of other links where the additional padding could cause display problems. Did you check whether this causes display problems in other table links?

Good point Joe, as far as I see column-posts is used only in this table. Will double check and maybe add a specific selector on the count links, just in case.

@afercia
9 years ago

#4 follow-up: @afercia
9 years ago

  • Focuses ui added
  • Keywords commit added

Refreshed patch adds a specific CSS selector for the posts count link to avoid possible conflicts, just in case. A bigger clickable area is good on smaller screens and doesn't harm on desktop. Of course it will be a bit bigger when the posts count number will have 2, 3, 4. etc. digits but seems the table column has a fixed width and is always large enough. Feel free to reduce it a bit if you feel it's too big. See screenshot.

https://cldup.com/nM_WeITXRc.png

#5 in reply to: ↑ 4 @obenland
9 years ago

Replying to afercia:

A bigger clickable area is good on smaller screens and doesn't harm on desktop.

It introduces a visual inconsistency with other lists, and also within the column between authors with posts and authors without. How about we limit the fix to just remove the title attribute for now?

#6 @afercia
9 years ago

Sure, will strip out that CSS part. Let's be aware the current links are not exactly comfortable to click, especially on smaller screens, see screenshot. Maybe something for @helen and the UI sweep.

https://cldup.com/FuYwMdynh7.png

@afercia
9 years ago

This ticket was mentioned in Slack in #design by afercia. View the logs.


9 years ago

#8 @afercia
9 years ago

Refreshed patch strips out any CSS change. Would propose for commit consideration.

#9 @obenland
9 years ago

  • Owner changed from afercia to obenland
  • Status changed from assigned to accepted

#10 @obenland
9 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32694:

Remove title attributes in user list tables.

They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.

#11 @afercia
7 years ago

  • Keywords title-attribute added
Note: See TracTickets for help on using tickets.