WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 6 years ago

#3259 closed enhancement (wontfix)

Should compress javascripts to save space

Reported by: alexkingorg Owned by: markjaquith
Milestone: Priority: normal
Severity: normal Version: 2.1
Component: General Keywords:
Focuses: Cc:

Description (last modified by foolswisdom)

Should compress javascripts to save space

Change History (18)

comment:1 markjaquith8 years ago

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Paging Andy Skelton:

Would this make Prototype upgrades more difficult? Any objections?

comment:2 andy8 years ago

As long as the only changes from the original script are whitespace, I wouldn't worry about code maintenance issues here.

comment:3 matt8 years ago

We never make any local mods or fork our JS libraries outside of our TinyMCE plugins.

I know the Dojo Toolkit folks and Alex Russell have a really kickass JS compression thing based on Rhino, perhaps we should run Prototype, DBX, and others through that to cut down on load times?

Online tools:

Someone should test to see which works best and we'll use it.

comment:4 masquerade8 years ago

Another library I've been using lately gets great compression by running their downloads through this class, and hasn't had any errors as some other compressors have been known to have.

http://www.phpclasses.org/browse/package/3158.html

comment:5 matt7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Addressed in [4566].

comment:6 foolswisdom7 years ago

  • Summary changed from Prototype script, spaces to tabs to Should compress javascripts to save space

comment:7 foolswisdom7 years ago

#3414 custom image header cropper error "_163 has no properties" in prototype.compress.js

comment:8 follow-up: alexkingorg7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9 follow-up: alexkingorg7 years ago

Also, I think the copyright info should be added back to the compressed versions.

comment:10 in reply to: ↑ 9 shorty1147 years ago

Replying to alexkingorg:

Also, I think the copyright info should be added back to the compressed versions.

Yes, if anything keep the header intact.

comment:11 Nazgul7 years ago

Because of the problems associated with this ticket, I suggest to push it out of scope for 2.1 and take a new look at it for the next release.

If we do push it out of scope I think we should take out prototype.compressed.js for now as well.

comment:12 in reply to: ↑ 8 foolswisdom7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Marking FIXED for 2.1 .

Replying to Nazgul:

Because of the problems associated with this ticket, I suggest to push it out of scope for 2.1 and take a new look at it for the next release.

That would upset me because this ticket has already resulted in changes. Better to have a new ticket for the next cycle of work.

If we do push it out of scope I think we should take out prototype.compressed.js for now as well.

prototype.compressed.js was already removed in [4592]

Replying to alexkingorg:

Also, I think the copyright info should be added back to the compressed versions.

I disagree. The original "source" version is in the same folder and the file naming is appropriate. Source is easy to locate in the distribution and on the net. I don't think authors will find this offensive.

Replying to alexkingorg:

This version gets it down to 25k:

Awesome! Something to explore for 2.2 . Will other libraries still be being considered?

comment:13 foolswisdom7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[4769] [4770] removed all the compression files. First removed quicktags.compressed.js because people have customized quicktags.js , and then all (it seems) because there are enough other big variables in this release.

comment:14 foolswisdom7 years ago

  • Milestone changed from 2.1 to 2.2

comment:15 foolswisdom7 years ago

  • Description modified (diff)

comment:16 foolswisdom7 years ago

  • Milestone changed from 2.2 to 2.4

comment:17 pishmishy6 years ago

  • Milestone changed from 2.5 to 2.6

Feature request so bumping to 2.6 for feature freeze.

comment:18 azaozz6 years ago

  • Milestone 2.9 deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

No traction since 2.1, also it seems it's better to capture all js files with Gears instead of compressing them.

Note: See TracTickets for help on using tickets.