WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#32660 closed defect (bug) (fixed)

'style_loader_tag' should receive a `$src` parameter

Reported by: boonebgorges's profile boonebgorges Owned by: boonebgorges's profile boonebgorges
Milestone: 4.3 Priority: normal
Severity: normal Version:
Component: Script Loader Keywords: good-first-bug has-patch
Focuses: Cc:

Description

The 'script_loader_tag' gets three arguments: $tag (the markup), $handle, and $src (the asset URL). 'style_loader_tag' only gets the first two of these. It should get $src as well. Patches should update the docs as required - and make sure you catch all instances of 'style_loader_tag'.

See [30403].

Attachments (1)

#32660_add_.patch​ (1.4 KB) - added by nicholas_io 10 years ago.
Patch that's add the $src attribute.

Download all attachments as: .zip

Change History (4)

@nicholas_io
10 years ago

Patch that's add the $src attribute.

#1 @nicholas_io
10 years ago

  • Keywords has-patch added; needs-patch removed

*Patch that adds the $src attribute.

Last edited 10 years ago by nicholas_io (previous) (diff)

#2 @boonebgorges
10 years ago

  • Milestone changed from Future Release to 4.3

nicholas_io - Thanks for the patch!

#3 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 32898:

Pass stylesheet URL as an argument to 'style_loader_tag' filter.

This change brings the filter's signature in line with 'script_loader_tag'.

Props nicholas_io.
Fixes #32660.

Note: See TracTickets for help on using tickets.