WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#32706 closed task (blessed) (fixed)

Press This: Enable HTML Editor

Reported by: kraftbj Owned by: azaozz
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords:
Focuses: Cc:

Description

"Old" Press This allowed you to switch between the Visual/Text TinyMCE editors. Ticket to track adding it to 4.2-era PT.

Needs:

  • Re-enable quicktags when setting up editor.
  • JS love to have the media picker and "Standard Editor" transition work.
  • CSS love for text mode toolbar to appear and for the switcher to not overlap with the flyout.

Attachments (5)

32706.patch (907 bytes) - added by kraftbj 2 years ago.
Initial patch enabling the editor picker
32706.1.patch (7.0 KB) - added by azaozz 2 years ago.
pre-ticket.png (153.7 KB) - added by kraftbj 2 years ago.
Screenshot of PT before any patches applied.
32706.1-wide.png (155.2 KB) - added by kraftbj 2 years ago.
With 32706.1 applied, wider browser window
32706.1-thin.png (123.7 KB) - added by kraftbj 2 years ago.
32706.1 applied on a thinner browser window with the tag/cat nav open revealing outstanding CSS problem.

Download all attachments as: .zip

Change History (21)

@kraftbj
2 years ago

Initial patch enabling the editor picker

#1 @kraftbj
2 years ago

32706.patch enables the quicktabs picker between the editor (explicitly, although the default is on) and adds CSS to ensure the buttons are visible. It uses the default icons at this time.

Needs JS love and how to fix the quicktabs appearing over the flyout panel on smaller screens. I couldn't figure out how to move it under without breaking the functionality of the quicktags (seen in https://cloudup.com/cgykphCKPOR )

@azaozz
2 years ago

#2 @azaozz
2 years ago

  • Milestone changed from Awaiting Review to 4.3

In 32706.1.patch:

  • Add support for the Text editor in PT, incl. inserting images/videos, etc.
  • Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
  • Add auto-resize for the textarea.

Still needs styling of the Visual | Text tabs and perhaps the Quicktags buttons.

#3 @stephdau
2 years ago

32706.1.patch is working very well in Chrome/Linux and Chrome/Android,including in "Disable the visual editor when writing" mode.

#4 @kraftbj
2 years ago

The "Save Draft" transition from "Standard Editor" back to "Save Draft" isn't firing in the text editor mode.

#5 @samuelsidler
2 years ago

Is this still on track for beta (on Wednesday)?

#6 @ryan
2 years ago

How about some screenshots to go with these patches? :-)

#7 @ryan
2 years ago

  • Keywords needs-screenshots added

@kraftbj
2 years ago

Screenshot of PT before any patches applied.

@kraftbj
2 years ago

With 32706.1 applied, wider browser window

@kraftbj
2 years ago

32706.1 applied on a thinner browser window with the tag/cat nav open revealing outstanding CSS problem.

#8 @kraftbj
2 years ago

  • Keywords needs-screenshots removed

#9 @azaozz
2 years ago

In 32999:

Press This:

  • Add support for the Text editor.
  • Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
  • Add auto-resize for the textarea.

See #32706.

#10 follow-ups: @azaozz
2 years ago

Leaving this open as the Visual and Text buttons may need a bit more styling.

Uh, also forgot to add props kraftbj for the initial patch, sry.

Last edited 2 years ago by azaozz (previous) (diff)

#11 in reply to: ↑ 10 @kraftbj
2 years ago

Replying to azaozz:

Uh, also forgot to add props kraftbj for the initial patch, sry.

I just need to find something else on PT to patch and get double-props. ;-)

This ticket was mentioned in Slack in #core by obenland. View the logs.


2 years ago

#13 @obenland
2 years ago

  • Keywords needs-patch added
  • Owner set to azaozz
  • Status changed from new to assigned
  • Type changed from enhancement to task (blessed)

#14 in reply to: ↑ 10 ; follow-up: @obenland
2 years ago

  • Keywords needs-patch removed

Replying to azaozz:

Leaving this open as the Visual and Text buttons may need a bit more styling.

Do they need more styling or can we close the ticket?

#15 in reply to: ↑ 14 @azaozz
2 years ago

Replying to obenland:

Lets close this for now (after couple more small tweaks). If somebody comes up with a patch to make the buttons look and feel better, we can always reopen :)

#16 @azaozz
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 33159:

Press This: make the font size in the Text editor similar to the Visual editor. Fix buttons padding.
Fixes #32706.

Note: See TracTickets for help on using tickets.