Refactor SCRIPT_FILENAME ending with php.cgi check in load.php

[wildpeat]

I found the original check pretty confusing :)

[wildpeat]

Patch

[dd32]

To avoid the usage of a regular expression here, this seems far more readable than the current odd code:

if ( isset( $_SERVER['SCRIPT_FILENAME'] ) && 'php.cgi' == substr( $_SERVER['SCRIPT_FILENAME'], -7 ) ) 

[wildpeat]

With the caveat that I'm brand new to PHP, I agree that's more readable than the original, but I don't like the constant -7 in the code. I have noticed this hardcoding of the string length in lots of other parts of the code-base and I'll gladly nod to your experience if this is more idiomatic in PHP than the regex.

Cheers for looking!

[jorbin]

In [56245] this was updated to use str_ends_with which accomplishes the goal of making this more readable, ergo I am closing this as a duplicate of #58206 which is what that was committed under. Thank you for your attempt to improve WordPress @wildpeat!