Wp Editor front end missing add media button

[alexandruias]

This is the code that I use to setup the wp editor in front-end.You can paste in a theme file.

<?php $content = 'none';

$settings = array(
	'media_buttons' => true,
	'drag_drop_upload' => true,
);

$editor_id ='customusername';

echo '<div style="float:right;max-width:600px">';
wp_editor($content,$editor_id,$settings);
echo '</div>';?>

In 4.2.3 the editor shows the add media button but the latest trunk doesn't.
In the trunk I can see with inspect element that is trying to generate the add media button but is only an empty div.

<div id="wp-customusername-media-buttons" class="wp-media-buttons"></div>

Everything is default no theme or plugin installed or activated.

[obenland]

Confirmed, @azaozz, @iseulde, could you take a look?

[ocean90]

Broken since [32653]. add_action( 'media_buttons', 'media_buttons' ); was moved to wp-admin/includes/admin-filters.php.

[azaozz]

Seems the straightforward way to fix this would be to add add_action( 'media_buttons', 'media_buttons' ); to class-wp-editor.php.

However likely there will be more cases of missing add_action and add_filter. Looking through the files from where the actions were moved, several more are sometimes included in non wp-admin context.

Reopening #32529 for further investigation.

[wonderboymusic]

33257.diff​ moves 3 filters to default-filters.php from admin-filters.php - the hooks get fired in the same file that contains the callbacks.

[azaozz]

33257.diff looks good.

[obenland]

Replying to azaozz:

33257.diff looks good.

With wonderboymusic's and your sign-off, this is ready to go in.

[markjaquith]

In 33590:

Move media hooks out of admin-filters.php as sometimes editors are used on the front end.

fixes #33257
props wonderboymusic