Customizer header image crop uses static URL when refreshing UI after crop.

[polevaultweb]

Once an image crop has been made for the Header image inside the Customizer, the new cropped attachment is created with the URL as the post content and this is passed back to the UI with JS, to update the header img.

However, if you reload the page the header images are retrieved using wp_get_attachment_url() which allows other plugins to filter on the URL.

The URL passed to the UI after crop should be created with the same function. Is there any need for the URL to also be stored in post_content for the attachment?

[polevaultweb]

Use wp_get_attachment_url for the cropped image URL

[westonruter]

The feature was introduced in #21785, specifically added in [27497].

@gcorne Is this something you can advise on?

[nerrad]

I'd like to second this patch, it makes it more consistent with other places attachment url is retrieved and used.

[nerrad]

seems like a related fix was made in #33386.

[wonderboymusic]

In 34188:

Similar to #33386, don't use guid when retrieving URL for a cropped header image in the Customizer.

Props polevaultweb.
Fixes #33319.

[wonderboymusic]

In 34214:

After [34188], fix unit test for image header.

See #33319.

[DrewAPicture]

In 34228:

Docs: Add a changelog entry for the switch to using wp_get_attachment_url() instead of the guid for determining the header image URL in Custom_Image_Header::step_3().

The change was introduced in [34188].

See #33319.