Opened 5 years ago
Last modified 14 months ago
#33388 new defect (bug)
WP_Theme should use get_file_data() for retrieving page templates
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | needs-testing close |
Focuses: | Cc: |
Description
Currently WP_Theme::get_page_templates() uses a direct regular expression on the result of get_file_contents()
, it should instead use the get_file_data()
helper method we have to interact with file header data.
Currently switching will result in a back-compat break, as some themes have been using headers such as <?php // Template Name: Something ?>
as the header, which get_file_data() doesn't like - See #33387
See r21117 for where we previously did use it temporarily during the 3.4 cycle, but broke due to #33387
Attachments (2)
Change History (5)
Note: See
TracTickets for help on using
tickets.
depends on #33387