Pagination - use of ellipsis / "..." not logic in some cases

[th23]

Hi there,

I believe there is some improvement potential in the logic of the pagination. The "..." indicator does not really serve its purpose, in case you have it only hiding one page link - see attached screenshot.

Would propose to change the function generating the pagination to only use it in case it at least covers 2 page links.

[th23]

Maybe its not high priority, but just closing is for me is not an option:

1) The helip requires more space than a normal number item, so on small screens showing it instead of 1 number makes it use more space in total

2) Its counter-intuitive of user expectation

Please consider fixing instead, if it's "trival"!

Thanks!

[luukdv]

Added a patch that checks if there is more than 1 page to be collapsed (with '...'), otherwise the default page link will be displayed.

[luukdv]

After some additional testing with different use cases and settings, the previous solution proved to be wrong. Added a new patch.

[SirLouen]

Replying to th23:

Maybe its not high priority, but just closing is for me is not an option:

I'm divided between the opinion of @wonderboymusic and the potential usefulness of this report

On one side it seems something interesting and well ideated, after all that ellipsis is "bigger than a number", but on the other side it feels like a very edge case, which forces adding more code for something that is really not that prominent.

Each line of code means maintenance, and I don't really think that the fact of adding this feature could be so valuable. In fact, it has been sitting here for 10 years, and I don't see many duplicates, so it doesn't seem highly demanded.

Having rushed to do a patch was not the best idea.

To gain perspective, other CMS like XenForo, implement this one you are commenting (maybe you got this idea from a XenForo site?)

But others like SMF doesn't

Drupal has another approach, but similarly weirder (instead of just putting the 1, they put the ellipsis)

And Joomla implements another entirely different one:

As we can see, there are no two CMS that provide the same pagination display. Also, pagination is something that could be extended, so if anyone wants a specific pagination system, you can easily write a new one.

Although, I think that more voices should comment on this topic before taking a final decision.

BTW, close tag as @wonderboymusic proposed, is just a special 2nd opinion tag to say, "I'm not completely sure if this is relevant, so I need another team member to check this and confirm, or not, if this should be closed". And this is what I'm doing now, again, but I'm going to also add 2nd-opinion, pinging some members I think might have some criteria on this topic.

cc @audrasjb @poena