WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 7 weeks ago

#33405 new enhancement

Pagination - use of helip / "..." not logic in some cases

Reported by: th23 Owned by:
Milestone: Priority: lowest
Severity: trivial Version: 4.2.4
Component: Themes Keywords: has-patch needs-testing
Focuses: ui, template Cc:

Description

Hi there,

I believe there is some improvement potential in the logic of the pagination. The "..." indicator does not really serve its purpose, in case you have it only hiding one page link - see attached screenshot.

Would propose to change the function generating the pagination to only use it in case it at least covers 2 page links.

Attachments (3)

pagination.jpg (24.2 KB) - added by th23 4 years ago.
33405.diff (900 bytes) - added by luukdv 3 years ago.
33405.2.diff (1.1 KB) - added by luukdv 3 years ago.

Download all attachments as: .zip

Change History (9)

@th23
4 years ago

#1 @wonderboymusic
4 years ago

  • Keywords close added
  • Priority changed from normal to lowest
  • Severity changed from normal to trivial

#2 @th23
4 years ago

  • Keywords close removed

Maybe its not high priority, but just closing is for me is not an option:

1) The helip requires more space than a normal number item, so on small screens showing it instead of 1 number makes it use more space in total

2) Its counter-intuitive of user expectation

Please consider fixing instead, if it's "trival"!

Thanks!

@luukdv
3 years ago

#3 @luukdv
3 years ago

Added a patch that checks if there is more than 1 page to be collapsed (with '...'), otherwise the default page link will be displayed.

#4 @luukdv
3 years ago

  • Keywords has-patch added

@luukdv
3 years ago

#5 @luukdv
3 years ago

After some additional testing with different use cases and settings, the previous solution proved to be wrong. Added a new patch.

#6 @luukdv
3 years ago

  • Keywords needs-testing added
Note: See TracTickets for help on using tickets.