Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33662 closed defect (bug) (fixed)

Method description missing in wp-includes/class-wp-walker.php

Reported by: wen-solutions's profile WEN Solutions Owned by: drewapicture's profile DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.4
Component: Administration Keywords:
Focuses: docs Cc:

Description

Description is missing in the File: wp-includes/class-wp-walker.php for Method: get_number_of_root_elements.

Attachments (1)

33662.diff (367 bytes) - added by WEN Solutions 9 years ago.

Download all attachments as: .zip

Change History (7)

@WEN Solutions
9 years ago

#1 @swissspidy
9 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.4
  • Owner set to DrewAPicture
  • Status changed from new to assigned

Looks good to me. Perhaps the spacing on the second line (386) should be removed though.

#2 @DrewAPicture
9 years ago

  • Keywords needs-patch added; has-patch removed

We should add the parameter and return descriptions and the @since while we're in there.

@wen-solutions: Would you like to add descriptions for the $elements parameter and the return while you're at it? I'll take care of hunting down the @since version.

#3 @DrewAPicture
9 years ago

Looks like the method was introduced in @since 2.7.0 in [8939].

#4 @DrewAPicture
9 years ago

In 33868:

Docs: Add a missing summary to the DocBlock for Walker::get_number_of_root_elements().

Props wen-solutions
See #33662.

#5 @DrewAPicture
9 years ago

  • Keywords needs-patch removed

#6 @DrewAPicture
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34121:

Docs: Add missing parameter and return descriptions for Walker::get_number_of_root_elements().

Fixes #33662.

Note: See TracTickets for help on using tickets.