WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#33809 closed defect (bug) (fixed)

Comment template hooks expect from $comment_ID to be integer

Reported by: dimadin's profile dimadin Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

I don't know if this was pre-4.4 behavior, but I have noticed after [33961] that many hooks in comment template function use $comment_ID and assume that it is integer.

I have changed variable in most places but in some I needed to introduce get_comment() so I would get comment_ID and used $comment instead.

Attachments (1)

33809.diff​ (5.7 KB) - added by dimadin 9 years ago.

Download all attachments as: .zip

Change History (3)

@dimadin
9 years ago

#1 @wonderboymusic
9 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.4
  • Owner set to wonderboymusic
  • Status changed from new to assigned

#2 @wonderboymusic
9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34008:

After [33961], ensure that comment filters that expect a comment ID are receiving one.

Props dimadin.
Fixes #33809.

Note: See TracTickets for help on using tickets.